Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove store retention limit in aggregator infra #845

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Remove store retention limit in aggregator infra #845

merged 1 commit into from
Apr 5, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 5, 2023 •
edited
Loading

Content

This PR includes a temporary fix for a panic that occurs on the store pruning of the epoch settings store

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #828

@jpraynaud jpraynaud marked this pull request as ready for review April 5, 2023 10:26
@jpraynaud jpraynaud temporarily deployed to testing-preview April 5, 2023 10:32 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Test Results

    3 files  ±0    30 suites  ±0   5m 51s ⏱️ +27s
522 tests ±0  522 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
598 runs  ±0  598 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4384dbd. ± Comparison against base commit 04905fd.

@jpraynaud jpraynaud changed the title Remove store retention limit aggregator in infra Remove store retention limit in aggregator infra Apr 5, 2023
@jpraynaud jpraynaud self-assigned this Apr 5, 2023
@jpraynaud jpraynaud merged commit 398bee7 into main Apr 5, 2023
@jpraynaud jpraynaud deleted the 828/fix-store-pruning-panic branch April 5, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpraynaud @ghubertpalo