Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Signable Builder Service in signer #903

Merged
merged 3 commits into from
May 9, 2023
Merged

Use Signable Builder Service in signer #903

merged 3 commits into from
May 9, 2023

Conversation

jpraynaud
Copy link
Member

Content

This PR includes the use of the Signable Builder Service by the signer runtime to compute protocol messages given a signed entity type

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #854

@github-actions
Copy link

github-actions bot commented May 4, 2023

Test Results

    3 files  ±0    30 suites  ±0   6m 22s ⏱️ +18s
571 tests ±0  571 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
647 runs  ±0  647 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 37da29b. ± Comparison against base commit 0ab4ef1.

@jpraynaud jpraynaud temporarily deployed to testing-preview May 4, 2023 15:41 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit c5ca321 into main May 9, 2023
@jpraynaud jpraynaud deleted the ensemble/854-use-signable-builder-service-signer branch May 9, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees

@Alenar Alenar

@jpraynaud jpraynaud

@ghubertpalo ghubertpalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt runtime to use signable builder service in signer
3 participants
@jpraynaud @Alenar @ghubertpalo