Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Rust 1.70.0 #959

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Upgrade Rust 1.70.0 #959

merged 3 commits into from
Jun 5, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 2, 2023 •
edited
Loading

Content

This PR includes fix for new clippy warnings with Rust 1.70.0 and fixes the tests failing in the CI because of use of -Z unstable-options in the cargo test command.

⚠️ We have deactivated the Publish Result job of the CI workflow

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #958

@jpraynaud jpraynaud self-assigned this Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023 •
edited
Loading

Test Results

3 files  ±    0  3 errors  0 suites   - 30   0s ⏱️ - 5m 41s
0 tests  - 574  0 ✔️  - 574  0 💤 ±0  0 ❌ ±0 
0 runs   - 606  0 ✔️  - 606  0 💤 ±0  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit fbaeb17. ± Comparison against base commit 27d5783.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/958-upgrade-rust-1.70.0 branch 2 times, most recently from 17c347f to fbaeb17 Compare June 5, 2023 07:25
@jpraynaud jpraynaud temporarily deployed to testing-preview June 5, 2023 07:33 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review June 5, 2023 07:38
@jpraynaud jpraynaud force-pushed the jpraynaud/958-upgrade-rust-1.70.0 branch from fbaeb17 to 9682d63 Compare June 5, 2023 07:59
@jpraynaud jpraynaud temporarily deployed to testing-preview June 5, 2023 08:12 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/958-upgrade-rust-1.70.0 branch from 9682d63 to aff26d5 Compare June 5, 2023 09:07
@jpraynaud jpraynaud temporarily deployed to testing-preview June 5, 2023 09:20 — with GitHub Actions Inactive
@jpraynaud
Fix CI test fails
18aa151 
Due to '-Z unstable-options' not being accepted by stable toolchain from Rust '1.70.0'.
@jpraynaud
Update crates versions
c8276dc
@jpraynaud jpraynaud force-pushed the jpraynaud/958-upgrade-rust-1.70.0 branch from aff26d5 to c8276dc Compare June 5, 2023 09:25
@jpraynaud jpraynaud temporarily deployed to testing-preview June 5, 2023 09:49 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested a review from Alenar June 5, 2023 10:00
@jpraynaud jpraynaud merged commit 5846354 into main Jun 5, 2023
@jpraynaud jpraynaud deleted the jpraynaud/958-upgrade-rust-1.70.0 branch June 5, 2023 10:01
@jpraynaud jpraynaud linked an issue Jun 7, 2023 that may be closed by this pull request
CI tests fail with Rust 1.70.0 #958
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI tests fail with Rust 1.70.0
2 participants
@jpraynaud @ghubertpalo