Bug: CIP-68 images not displayed correctly #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
force-pushed
the
main
branch
5 times, most recently
from
9dd4cd2
to
4b947a6
Compare
|
Just came across this issue too. Looks like a simple fix. Any idea how to get this merge unblocked? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a bug while working with CIP68 tokens, specifically in handling key-value pairs where the value exceeds 64 letters. In such cases, there's a need to split the string into an array of multiple strings. This bug is affecting the correct display of images and the identification of the CIP-68 tokens in Nami wallet.
Not working in CIP-68
{ "name": "...", "image": ["ipfs://", "bafkreicoobvutqxnxodrjzyd3h72da67hc2jpuivogsehvzl6zglhnbncq"] }The fix involves passing the prop into the conversion method before transforming it into a source.