Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fs-api and fs-sim packages to the fs-sim repo. #4460

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

jorisdral
Copy link
Contributor

@jorisdral jorisdral commented Mar 16, 2023

Description

Part of #4082.

This PR removes the fs-api and fs-sim packages from the ouroboros-network repository. The code is added to the fs-sim repository in this PR: input-output-hk/fs-sim#2.

For now, we will have a source-repository-package entry in the cabal.project file, which can be removed once both fs-sim and fs-api are published to the CHaP.

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
    • Any changes in the Consensus API (every exposed function, type or module) that has changed its name, has been deleted, has been moved, or altered in some other significant way must leave behind a DEPRECATED warning that notifies downstream consumers. If deprecating a whole module, remember to add it to ./scripts/ci/check-stylish.sh as otherwise stylish-haskell would un-deprecate it.
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@jorisdral jorisdral added consensus issues related to ouroboros-consensus open-source labels Mar 16, 2023
@jorisdral jorisdral requested a review from a team March 16, 2023 10:34
@jorisdral jorisdral self-assigned this Mar 16, 2023
@jorisdral jorisdral requested a review from nfrisby as a code owner March 16, 2023 10:34
@jorisdral jorisdral force-pushed the jdral/migrate-fs-sim-packages branch from f1f3adc to a34189f Compare March 16, 2023 10:36
@jorisdral
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 17, 2023

@iohk-bors iohk-bors bot merged commit 65c11fc into master Mar 17, 2023
@iohk-bors iohk-bors bot deleted the jdral/migrate-fs-sim-packages branch March 17, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus open-source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants