Migrate fs-api and fs-sim packages from ouroboros-network repo.
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/migrate-packages
branch
2 times, most recently
from
0549b1a to
c02c687
Compare
jorisdral
force-pushed
the
jdral/migrate-packages
branch
from
c02c687 to
13a1cfa
Compare
11 tasks
dnadales
reviewed
Mar 16, 2023
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Not for this PR, but I wonder if we want to invest time in abstracting away this CI setup we replicate in multiple repos.
There was a problem hiding this comment.
I will create an issue for this
dnadales
reviewed
Mar 16, 2023
| @@ -1,4 +1,4 @@ | |||
| # Release process | |||
|
|
|||
| See the [consensus release | |||
| process](https://github.com/input-output-hk/ouroboros-network/blob/master/ouroboros-consensus/docs/ReleaseProcess.md). | |||
| process](https://github.com/input-output-hk/ouroboros-consensus/blob/master/docs/ReleaseProcess.md). | |||
There was a problem hiding this comment.
Idem #2 (comment)
dnadales
reviewed
Mar 16, 2023
There was a problem hiding this comment.
Do we want to add a cabal formatter to our CI?
There was a problem hiding this comment.
Idem #2 (comment)
dnadales
reviewed
Mar 16, 2023
| , write | ||
| ) where | ||
|
|
||
| import Prelude hiding (read, truncate) |
There was a problem hiding this comment.
Do we want to put all the imports together?
There was a problem hiding this comment.
Idem #2 (comment)
dnadales
approved these changes
Mar 16, 2023
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Mar 17, 2023
4460: Migrate `fs-api` and `fs-sim` packages to the `fs-sim` repo. r=jorisdral a=jorisdral # Description Part of #4082. This PR removes the `fs-api` and `fs-sim` packages from the `ouroboros-network` repository. The code is added to the `fs-sim` repository in this PR: input-output-hk/fs-sim#2. For now, we will have a `source-repository-package` entry in the `cabal.project` file, which can be removed once both `fs-sim` and `fs-api` are published to the CHaP. Co-authored-by: Joris Dral <joris@well-typed.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of IntersectMBO/ouroboros-network#4082.
This PR migrates the
fs-apiandfs-simpackages from theouroboros-networkrepository to the current repository. The code is copied as-is from the ouroboros-network#0659e7b7ef66b01763cdf15c2f8777a9394c248d commit . We also add a GitHub Actions workflow file, and a script for running thestylish-haskellformatter.Follow-up TODOs:
fs-api) and simulated file system (fs-sim) fromouroboros-consensusandouroboros-consensus-test. IntersectMBO/ouroboros-network#4425