Task/psgs 44 sub 56 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to add here it:test into CI, will do this today |
mcsherrylabs
approved these changes
Oct 2, 2020
build.sbt
Outdated
| dynverSonatypeSnapshots in ThisBuild := true, | ||
| javacOptions ++= Seq("-source", "1.8", "-target", "1.8"), | ||
| scalacOptions ++= Seq("-unchecked", "-deprecation", "-Ymacro-annotations"), | ||
| parallelExecution in Test := false, |
There was a problem hiding this comment.
We should be able to remove this for unit tests?
| println(s"WALLET 1 words ${aryLen} <-") | ||
| println(s"WALLET 2 words ${aryLen2} <-") | ||
| println(s"WALLET 1 words $aryLen <-") | ||
| println(s"WALLET 2 words $aryLen2 <-") |
There was a problem hiding this comment.
These can go. My bad.
There was a problem hiding this comment.
(Well they were needed for debugging CI, but they are not needed anymore)
There was a problem hiding this comment.
ok will get rid of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests in "it" folder, also moved by the way already apiExecutor so will be easier to create unit tests
( pointing PR to another branch, so only it test changes will be visible here )