Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-compile to Scala.js #98

Merged
merged 36 commits into from
Jan 20, 2023
Merged

Cross-compile to Scala.js #98

merged 36 commits into from
Jan 20, 2023

Conversation

aslesarenko
Copy link
Contributor

@aslesarenko aslesarenko commented Sep 10, 2022 •
edited
Loading

In this PR:

  • CI configuration for Scala.js
  • configuration of SBT with necessary JS dependencies (@noble/hashes) using ScalablyTyped
  • removed all Java dependencies
  • necessary code changes for Scala.js cross-compilation
  • some classes moved to JVM-only module

@aslesarenko aslesarenko marked this pull request as draft September 10, 2022 15:50
@aslesarenko
scala-js: removed org.whispersystems dependency and Curve25519
c4c0805
@aslesarenko
scala-js: configure cross-platform sbt setup
18736a6
@aslesarenko
scala-js: update scorex-util dependency
b79798c
@aslesarenko
scala-js: remove unused declarations
89add8a
@aslesarenko
scala-js: remove scala-logging dependence
c99a931
@aslesarenko
scala-js: move to JVM: Blake2b256Unsafe
22b3dca
@aslesarenko
scala-js: move to JVM: Blake2b512Specification
4fe303b
@aslesarenko
scala-js: move to JVM: Blake2b512
3b9ae72
@aslesarenko
scala-js: move to JVM: KeccakSpecification
2676e4b
@aslesarenko
scala-js: move to JVM: Keccak
e127667
@aslesarenko
scala-js: move to JVM: Whirlpool
054277f
@aslesarenko
scala-js: move to JVM: Stribog
0fbb8a8
@aslesarenko
scala-js: move to JVM: Skein + Sha256Unsafe
cd4e049
@aslesarenko
scala-js: move to JVM: CryptographicHash64 + ThreadUnsafeHash
59eedd5
@aslesarenko
scala-js: reimplement Blake2b256 via Platform.scala
6fa1d57
@aslesarenko
scala-js: reimplement Sha256 via Platform.scala
91b869f
@aslesarenko
scala-js: configure benchmarks project
727c7a8
@aslesarenko
scala-js: enable JSPlatform
dcd9953
@aslesarenko
scala-js: make code and tests compile
e4a8d3e
@aslesarenko
scala-js: Platform implemented for JS
b9f974e
@aslesarenko
scala-js: make all JS tests pass
546c402
@aslesarenko
scala-js: setup ci.yml
dafca54
@aslesarenko
scala-js: ScalaJsSpec.scala added
27fb071
@aslesarenko
scala-js: more tests for ScalaJsSpec
e49a312
@aslesarenko
scala-js: add Scala 2.12 to JS tests and publishing
e96eb00
@aslesarenko aslesarenko marked this pull request as ready for review December 19, 2022 21:09
kushti
kushti requested changes Dec 27, 2022
View reviewed changes
Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • release-notes update is missed (I think it makes sense to release 3.0.0 version)

js/src/main/scala/scorex/crypto/hash/Platform.scala Show resolved Hide resolved
js/src/main/scala/scorex/crypto/BouncycastleJs.scala Outdated Show resolved Hide resolved
jvm/src/main/scala/scorex/crypto/hash/Platform.scala Show resolved Hide resolved
shared/src/main/scala/scorex/crypto/hash/BouncyCastleHash.scala Show resolved Hide resolved
@aslesarenko aslesarenko force-pushed the scala-js branch 6 times, most recently from 75d029f to 49a775f Compare December 31, 2022 09:59
kushti
kushti requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update readme with instructions on compiling and building, sbt compile does not work without additional steps anymore it seems

release-notes.md Outdated Show resolved Hide resolved
release-notes.md Outdated Show resolved Hide resolved
kushti
kushti requested changes Jan 17, 2023
View reviewed changes
js/src/main/scala/scorex/crypto/hash/Platform.scala Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
shared/src/test/scala/scorex/ScalaJsSpec.scala Show resolved Hide resolved
@kushti kushti merged commit 59c4fbd into input-output-hk:master Jan 20, 2023
This was referenced Jan 21, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushti kushti kushti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslesarenko @kushti