Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set rawValue for a case if it is the same as it's name #99

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Don't set rawValue for a case if it is the same as it's name #99

merged 2 commits into from
Aug 16, 2019

Conversation

RomanPodymov
Copy link
Contributor

@RomanPodymov RomanPodymov commented Aug 13, 2019

Hello.
Thank you for this utility. It saves a lot of time.
In this pull request I fixed #98.
Before:

enum CodingKeys: String, CodingKey {
    case anyCase = "anyCase"
}

After:

enum CodingKeys: String, CodingKey {
    case anyCase
}

Updated gems.

@insanoid insanoid merged commit 93f74c9 into insanoid:master Aug 16, 2019
@RomanPodymov
Copy link
Contributor Author

Hello @insanoid
Thank you for your approval. But I see that I set wrong target branch for this pull request, it should be dev, not master. Should I create a new pull request to dev with these changes?

@insanoid
Copy link
Owner

It's fine for now, I forgot to set as default. I will just make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants