Support oauth2client 1.5.1 #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2015 16:55
old_run has been completely removed in oauth2client 1.5.1. googleapis/oauth2client#285
|
That actually doesn't give full functionality when doing authentication. It is a patch that should preserve working setups but it means the necessary parameters are never passed back to the Google API. If you look at the argparse-over-flags branch you can see what a total fix entails ;) We are aware that this is not ideal, but to make sure it works all the time for everyone this is the option until I merge that branch. Sent from my iPhone
|
|
I would say that it should continue to work like normal. The only time I saw an issue was when I tried a new authentication. But I have a fairly set pattern of usage and there aren't any unit tests to prove that nothing else broke so YMMV. Sent from my iPhone
|
|
Thank you :) |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 30, 2016
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) MFH: 2016Q3 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@419306 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 30, 2016
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) MFH: 2016Q3
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 30, 2016
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) Approved by: ports-secteam (blanket)
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 2, 2016
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) Approved by: ports-secteam (blanket)
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 1, 2021
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) Approved by: ports-secteam (blanket)
svmhdvn
pushed a commit
to svmhdvn/freebsd-ports
that referenced
this pull request
Jan 10, 2024
gcalcli requires a dependency on oauth2client <= 1.4.12 to work
correctly, as higher versions replaced the run() method with run_flow().
The version of oauth2client in ports is 2.2.0 at the time of writing.
Fixes for the issue [1][2][3] have been submitted upstream in multiple
cases, although upstream has closed them as duplicates of a refactor
issue [4] that is yet to be committed/resolved.
This commit commits the proposed change in issue #229 [2].
While I'm here:
* Explicitly specify (and limit) supported Python versions to -2.x
* Add python to CATEGORIES
* Group, re-order and sort USE{s}, NO_* and files/plist sections
* Capitalize OPTIONS descriptions
[1] insanum/gcalcli#211
[2] insanum/gcalcli#229
[3] insanum/gcalcli#244
[4] insanum/gcalcli#165
PR: 206045
Submitted by: Lawrence Chen <beastie tardisi com>
Approved by: portmgr (maintainer timeout, 6+ months)
MFH: 2016Q3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My placing a harddepend on oauthclient<=1.4.12 was keeping gcalcli users on Arch Linux from completely upgrading their systems. gcalcli as-is doesn't work as old_run is completely removed from oauth2client 1.5.1. A simple workaround is in-place.
I've only tested
gcalcli agendaa bit; no issues so far. If there's a specific test I can do, please let me know.Relevant issues/pr's: #204 #123 #165