-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support oauth2client 1.5.1 #211
Conversation
old_run has been completely removed in oauth2client 1.5.1. googleapis/oauth2client#285
That actually doesn't give full functionality when doing authentication. It is a patch that should preserve working setups but it means the necessary parameters are never passed back to the Google API. If you look at the argparse-over-flags branch you can see what a total fix entails ;) We are aware that this is not ideal, but to make sure it works all the time for everyone this is the option until I merge that branch. Sent from my iPhone
|
I would say that it should continue to work like normal. The only time I saw an issue was when I tried a new authentication. But I have a fairly set pattern of usage and there aren't any unit tests to prove that nothing else broke so YMMV. Sent from my iPhone
|
Thank you :) |
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) MFH: 2016Q3 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@419306 35697150-7ecd-e111-bb59-0022644237b5
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) MFH: 2016Q3
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) Approved by: ports-secteam (blanket)
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) Approved by: ports-secteam (blanket)
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) Approved by: ports-secteam (blanket)
gcalcli requires a dependency on oauth2client <= 1.4.12 to work correctly, as higher versions replaced the run() method with run_flow(). The version of oauth2client in ports is 2.2.0 at the time of writing. Fixes for the issue [1][2][3] have been submitted upstream in multiple cases, although upstream has closed them as duplicates of a refactor issue [4] that is yet to be committed/resolved. This commit commits the proposed change in issue #229 [2]. While I'm here: * Explicitly specify (and limit) supported Python versions to -2.x * Add python to CATEGORIES * Group, re-order and sort USE{s}, NO_* and files/plist sections * Capitalize OPTIONS descriptions [1] insanum/gcalcli#211 [2] insanum/gcalcli#229 [3] insanum/gcalcli#244 [4] insanum/gcalcli#165 PR: 206045 Submitted by: Lawrence Chen <beastie tardisi com> Approved by: portmgr (maintainer timeout, 6+ months) MFH: 2016Q3
My placing a harddepend on oauthclient<=1.4.12 was keeping gcalcli users on Arch Linux from completely upgrading their systems. gcalcli as-is doesn't work as old_run is completely removed from oauth2client 1.5.1. A simple workaround is in-place.
I've only tested
gcalcli agenda
a bit; no issues so far. If there's a specific test I can do, please let me know.Relevant issues/pr's: #204 #123 #165