Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readfile.read_isce_xml: bugfix when v_first=0 #853

Merged
merged 1 commit into from
Sep 23, 2022
Merged

readfile.read_isce_xml: bugfix when v_first=0 #853

merged 1 commit into from
Sep 23, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Sep 23, 2022 •
edited
Loading

Description of proposed changes

  • readfile.read_isce_xml: bugfix when v_first=0, which is a valid value

  • installation: add recommend to the pip install dev mode

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz
readfile.read_isce_xml: bugfix when v_first=0
3996dfe 
+ readfile.read_isce_xml: bugfix when v_first=0, which is a valid value

+ installation: add recommend to the pip install dev mode
@yunjunz yunjunz merged commit 9ca4adc into insarlab:main Sep 23, 2022
@yunjunz yunjunz deleted the bugfix branch September 23, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yunjunz