Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug while geocoding complex wrapped interferogram #957

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix bug while geocoding complex wrapped interferogram #957

merged 2 commits into from
Feb 9, 2023

Conversation

comma-never-coma
Copy link
Contributor

@comma-never-coma comma-never-coma commented Feb 9, 2023

Description of proposed changes
There is something wrong while geocoding a wrapped interferograms in complex type due to ComplexWarning. The change would fix it as below.#955

Reminders

@welcome
Copy link

welcome bot commented Feb 9, 2023

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

@yunjunz yunjunz changed the title Update geocode.py fix bug while geocoding complex wrapped interferogram Feb 9, 2023
@yunjunz yunjunz self-requested a review February 9, 2023 09:10
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @comma-never-coma!

@yunjunz yunjunz merged commit 67ec693 into insarlab:main Feb 9, 2023
@welcome
Copy link

welcome bot commented Feb 9, 2023

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problems in geocoding wrapped interferograms in complex type
2 participants