see #1245: test when the ttl cache is cleared, should reset notificat…

…ion flag test passing

src/wordlift/admin/class-key-validation-notice.php

@@ -83,18 +83,19 @@ private function is_key_valid() {
 		}
 
 		$is_valid = $this->key_validation_service->is_key_valid( $key );
+
+		// when the cache is set, clear the notification flag.
+		delete_option( self::NOTIFICATION_OPTION_KEY );
+
 		$this->ttl_cache_service->put( self::CACHE_KEY, $is_valid );
 
 		return $is_valid;
 	}
 
 	private function display_key_validation_notice() {
 		add_action( 'admin_notices', function () {
-			$is_notification_shown = get_option( self::NOTIFICATION_OPTION_KEY, false );
 
-			if ( $is_notification_shown ) {
-				return;
-			}
+			$is_notification_shown = get_option( self::NOTIFICATION_OPTION_KEY, false );
 
 			$key = $this->configuration_service->get_key();
 
@@ -107,6 +108,10 @@ private function display_key_validation_notice() {
 				return;
 			}
 
+			if ( $is_notification_shown ) {
+				return;
+			}
+
 			$this->show_notification();
 
 		} );