Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete API #607

Closed
ziodave opened this issue Sep 3, 2017 · 0 comments
Closed

Autocomplete API #607

ziodave opened this issue Sep 3, 2017 · 0 comments
Assignees
@stoyan0v
Milestone
3.15

Comments

@ziodave
Copy link
Member

ziodave commented Sep 3, 2017

Create an API end-point for the Autocomplete API. The API end-point is called by the local front-end scripts (such as /admin-ajax.php?action=wl_autocomplete&query={query}). The request is forwarded to WordLift Server along with WordLift's key and language.

The API should make use of nonce value if possible.
@ziodave ziodave added this to the 3.15 milestone Sep 3, 2017
stoyan0v added a commit that referenced this issue Sep 4, 2017
@stoyan0v
see #607: Introduce WordLift_Autocomplete_Service & Wordlift_Autocomp…
5d8d4f6 
…lete_Adapter
stoyan0v added a commit that referenced this issue Sep 4, 2017
@stoyan0v
see #607: Introduce WordLift_Autocomplete_Service & Wordlift_Autocomp…
2c49ae0 
…lete_Adapter

Add better comments
@stoyan0v stoyan0v mentioned this issue Sep 4, 2017
Merged
stoyan0v added a commit that referenced this issue Sep 5, 2017
@stoyan0v
see #607: minor changes to the comments to respect codeclimate checks
89bdd16
ziodave added a commit that referenced this issue Sep 6, 2017
@ziodave
see #607: disabling rule 'wp_remote_get() is highly discouraged, plea…
5a56a2a 
…se use vip_safe_wp_remote_get() instead.'
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: fix codeclimate notices
4ebacbb
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: fix codeclimate issues
99fd51f
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: add coma adter each array element
f4749ee
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: sanitize query param to avoid codeclimate notice
0d5d420
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: check if nonce isset
0d7442c
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: replace spaces with tabs
d76840b
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: add comment at the end of each line that has global var to …
940e088 
…prevent notices
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: sanitize nonce value
199927d
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: add autocomplete tests
f5c02ae
stoyan0v added a commit that referenced this issue Sep 6, 2017
@stoyan0v
see #607: remove additional slash. Fix typos
dc853e7
stoyan0v added a commit that referenced this issue Sep 7, 2017
@stoyan0v
see #607: return better error messages, make build_request_url private
9f0b6b7
stoyan0v added a commit that referenced this issue Sep 7, 2017
@stoyan0v
see #607: add missing coma, after array element
e29dc27
stoyan0v added a commit that referenced this issue Sep 7, 2017
@stoyan0v
see #607: add more tests for autocomplete feature
a7be8c6
stoyan0v added a commit that referenced this issue Sep 7, 2017
@stoyan0v
see #607: make error messages translatable
5956632
stoyan0v added a commit that referenced this issue Sep 7, 2017
@stoyan0v
see #607: add translators comment
c81200b
stoyan0v added a commit that referenced this issue Sep 7, 2017
@stoyan0v
see #607: Add addional string to error message. Change tests expected…
eeb5f8d 
… responses
ziodave added a commit that referenced this issue Sep 10, 2017
@ziodave
see #607: disable WP's update checks since we're mangling the wp_remo…
112c20f 
…te_ requests
@ziodave ziodave added the merged label Sep 21, 2017
@ziodave ziodave closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stoyan0v stoyan0v

Labels
None yet
Projects
None yet
Milestone
3.15
Development

No branches or pull requests
2 participants
@ziodave @stoyan0v