Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ard_total_n() #258

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Adding ard_total_n() #258

merged 4 commits into from
Jun 13, 2024

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Jun 12, 2024

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #236


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Jun 12, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  --------------------------
R/apply_fmt_fn.R                  95      24  74.74%   36-43, 109-116, 198-205
R/ard_attributes.R                33       0  100.00%
R/ard_categorical.R              337      16  95.25%   225, 385-386, 542-557, 591
R/ard_complex.R                   34       0  100.00%
R/ard_continuous.R               176       4  97.73%   118, 200-201, 299
R/ard_dichotomous.R               66       2  96.97%   60, 146
R/ard_hierarchical.R              83       0  100.00%
R/ard_missing.R                   56       0  100.00%
R/ard_stack.R                     76       1  98.68%   107
R/ard_total_n.R                    7       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      22       3  86.36%   51-53
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  71       1  98.59%   60
R/print_ard_conditions.R          75      66  12.00%   60-176
R/print.R                         72       0  100.00%
R/process_selectors.R            125       1  99.20%   334
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shift_ard_columns.R             77      13  83.12%   61, 69, 144-147, 150-156
R/shuffle_ard.R                  102       0  100.00%
R/summary_functions.R             25       1  96.00%   59
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1778     150  91.56%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  --------
R/ard_stack.R         +6       0  +0.11%
R/ard_total_n.R       +7       0  +100.00%
TOTAL                +13       0  +0.06%

Results for commit: 2b805a2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   87 suites   14s ⏱️
 85 tests  54 ✅ 31 💤 0 ❌
175 runs  129 ✅ 46 💤 0 ❌

Results for commit a2270c0.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Unit Tests Summary

  1 files   89 suites   13s ⏱️
 87 tests  55 ✅ 32 💤 0 ❌
177 runs  130 ✅ 47 💤 0 ❌

Results for commit 2b805a2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_total_n 👶 $+0.09$ $+1$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_stack 👶 $+0.00$ ard_stack_adding_total_N
ard_total_n 👶 $+0.09$ ard_total_n_works

Results for commit 0fd32ce

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg requested a review from bzkrouse June 12, 2024 17:28
Copy link
Collaborator

@bzkrouse bzkrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great thank you for adding it!

@ddsjoberg ddsjoberg requested a review from bzkrouse June 13, 2024 16:43
@ddsjoberg ddsjoberg merged commit e1789e4 into main Jun 13, 2024
35 checks passed
@ddsjoberg ddsjoberg deleted the 236-total-n-ard branch June 13, 2024 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to get *total* population N ?
2 participants