Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardx readme update #137

Merged
merged 12 commits into from
Apr 30, 2024
Merged

cardx readme update #137

merged 12 commits into from
Apr 30, 2024

Conversation

ayogasekaram
Copy link
Contributor

@ayogasekaram ayogasekaram commented Apr 26, 2024

update readme with description

closes #105

Adding installation instructions, brief introduction and summary


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom", reference_pkg = "cardx") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Apr 26, 2024

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ------------------------------------
R/ard_aod_wald_test.R                 77       8  89.61%   36-41, 91, 94
R/ard_car_anova.R                     45       2  95.56%   62, 65
R/ard_car_vif.R                       61       2  96.72%   52, 86
R/ard_effectsize_cohens_d.R           88       2  97.73%   66, 111
R/ard_effectsize_hedges_g.R           82       2  97.56%   65, 115
R/ard_emmeans_mean_difference.R       70       0  100.00%
R/ard_proportion_ci.R                 42       5  88.10%   68-72
R/ard_regression_basic.R              16       1  93.75%   46
R/ard_regression.R                    51       0  100.00%
R/ard_smd_smd.R                       55       1  98.18%   48
R/ard_stats_anova.R                   95       0  100.00%
R/ard_stats_aov.R                     36       0  100.00%
R/ard_stats_chisq_test.R              39       1  97.44%   39
R/ard_stats_fisher_test.R             41       1  97.56%   39
R/ard_stats_kruskal_test.R            35       1  97.14%   38
R/ard_stats_mcnemar_test.R            79       2  97.47%   63, 105
R/ard_stats_mood_test.R               48       1  97.92%   46
R/ard_stats_oneway_test.R             31       0  100.00%
R/ard_stats_prop_test.R               82       1  98.78%   40
R/ard_stats_t_test.R                 110       2  98.18%   62, 108
R/ard_stats_wilcox_test.R             97       2  97.94%   62, 114
R/ard_survey_svychisq.R               37       1  97.30%   44
R/ard_survey_svycontinuous.R         193       2  98.96%   169, 179
R/ard_survey_svyranktest.R            51       0  100.00%
R/ard_survey_svyttest.R               50       0  100.00%
R/ard_survival_survdiff.R             89       0  100.00%
R/ard_survival_survfit.R             180       8  95.56%   79-81, 85, 95-97, 247
R/construction_helpers.R              57       6  89.47%   143, 155-159
R/proportion_ci.R                    194      28  85.57%   290, 293, 302-307, 315, 330, 431-454
TOTAL                               2131      79  96.29%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 0a4dd78

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Unit Tests Summary

  1 files   64 suites   10s ⏱️
 64 tests  44 ✅ 20 💤 0 ❌
181 runs  149 ✅ 32 💤 0 ❌

Results for commit 0a4dd78.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_emmeans_mean_difference 💀 $0.06$ $-0.06$ $-9$ $0$ $0$ $0$
construction_helpers 💀 $0.31$ $-0.31$ $-1$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_emmeans_mean_difference 💀 $0.06$ $-0.06$ ard_emmeans_mean_difference_works
ard_regression 💀 $0.01$ $-0.01$ ard_regression_does_not_produce_variable_level_column_where_not_applicable
ard_regression_basic 💀 $0.02$ $-0.02$ ard_regression_basic_does_not_produce_variable_level_column_where_not_applicable
construction_helpers 💀 $0.31$ $-0.31$ construct_model_works

Results for commit 8a771cf

♻️ This comment has been updated with latest results.

@ayogasekaram ayogasekaram changed the title cardx readme update init commit cardx readme update Apr 26, 2024
Merge branch '105_update_readme@main' of github.com:insightsengineering/cardx into 105_update_readme@main

# Conflicts:
#	inst/WORDLIST
@ddsjoberg ddsjoberg self-requested a review April 26, 2024 19:25
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ayogasekaram !! Can we make a couple small changes?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Apr 29, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@ayogasekaram
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

README.Rmd Show resolved Hide resolved
README.Rmd Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
@ddsjoberg
Copy link
Collaborator

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for making this cute!!

@ddsjoberg ddsjoberg merged commit 275cf35 into main Apr 30, 2024
31 checks passed
@ddsjoberg ddsjoberg deleted the 105_update_readme@main branch April 30, 2024 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the README cute
2 participants