Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing egt* tests and snapshots #397

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

edelarua
Copy link
Contributor

Closes #387

@edelarua edelarua added the sme label Feb 16, 2023
@edelarua edelarua enabled auto-merge (squash) February 16, 2023 18:19
@github-actions
Copy link
Contributor

🧪 $Test coverage: 91.56%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------------------------------------------------------
R/aet01_aesi.R                 188       8  95.74%   39, 41-45, 272, 285
R/aet01.R                      330       6  98.18%   38, 240, 253, 316, 322, 554
R/aet02.R                      222       2  99.10%   136, 489
R/aet03.R                       84       0  100.00%
R/aet04.R                       93       0  100.00%
R/assertions.R                  36       0  100.00%
R/checks.R                      20       0  100.00%
R/chevron_tlg-S4class.R         21       0  100.00%
R/chevron_tlg-S4methods.R      123      17  86.18%   35, 94-102, 137-145, 396-468
R/cmt01a.R                     191       0  100.00%
R/cmt02_pt.R                    52       0  100.00%
R/dmt01.R                       40       0  100.00%
R/dst01.R                      287       0  100.00%
R/dtht01.R                     104       0  100.00%
R/egt01.R                       46       0  100.00%
R/egt02.R                       60       0  100.00%
R/egt03.R                      132       3  97.73%   120, 166, 324
R/egt05_qtcat.R                 57       0  100.00%
R/ext01.R                       81       8  90.12%   238-241, 245-248
R/gen_args.R                     1       1  0.00%    30
R/lbt01.R                       95       0  100.00%
R/lbt04.R                       52       1  98.08%   127
R/lbt05.R                       76      10  86.84%   33-41, 152
R/lbt07.R                       87       1  98.85%   171
R/lbt14.R                      202      34  83.17%   57, 59, 107-110, 112-120, 150, 181, 268, 270, 318-321, 323-331, 361, 392
R/mht01.R                       72       2  97.22%   33-34
R/mng01.R                       93      12  87.10%   112, 116-119, 128-136, 181
R/pdt01.R                       61      38  37.70%   35-52, 108-150
R/pdt02.R                       68       0  100.00%
R/utils.R                      192     134  30.21%   70, 83-239, 400
R/vst01.R                       48       0  100.00%
R/vst02.R                      102       3  97.06%   42, 120, 257
TOTAL                         3316     280  91.56%

Results for commit: 522eb8c8ccb78725394038bacaa943630de063fc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    26 suites   1m 27s ⏱️
124 tests   86 ✔️ 38 💤 0
270 runs  179 ✔️ 91 💤 0

Results for commit bcf91f5.

@github-actions
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
default_tlg 💚 $45.97$ $-8.39$ $+3$ $+3$ $0$ $0$
dst01 💚 $7.10$ $-1.73$ $0$ $0$ $0$ $0$
empty_report 💚 $9.84$ $-1.69$ $+1$ $0$ $0$ $0$
lbt14 💚 $8.58$ $-1.86$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
default_tlg 👶 $+2.68$ egt01_1_functions_with_default_argument_value_return_expected_result_with_test_data
default_tlg 👶 $+0.35$ egt03_1_functions_with_default_argument_value_return_expected_result_with_test_data
default_tlg 👶 $+0.35$ egt03_2_functions_with_default_argument_value_return_expected_result_with_test_data
default_tlg 👶 $+0.95$ egt05_qtcat_1_functions_with_default_argument_value_return_expected_result_with_test_data
default_tlg 💀 $3.38$ $-3.38$ gt01_1_functions_with_default_argument_value_return_expected_result_with_test_data
default_tlg 💚 $13.63$ $-3.30$ vst01_1_functions_with_default_argument_value_return_expected_result_with_test_data
empty_report 💚 $9.84$ $-1.69$ tlg_functions_return_null_reports_when_domain_table_is_empty

Results for commit 522eb8c8ccb78725394038bacaa943630de063fc

♻️ This comment has been updated with latest results.

Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the update

@edelarua edelarua merged commit 316607c into main Feb 17, 2023
@edelarua edelarua deleted the 387_egt05_qtcat_tests@main branch February 17, 2023 06:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

egt05_qtcat empty table test
2 participants