Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

61 Create list2rules #62

Merged
merged 3 commits into from
Mar 8, 2023
Merged

61 Create list2rules #62

merged 3 commits into from
Mar 8, 2023

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Mar 8, 2023

create list2rules function

thank you for the review.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

🧪 $Test coverage: 93.51%$

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  -----------------
R/assertions.R            54       0  100.00%
R/co_relevels.R           17       0  100.00%
R/cut_by_group.R          15       0  100.00%
R/dm_explicit_na.R        35       1  97.14%   51
R/dm_unite.R              31       0  100.00%
R/join_adsub_adsl.R       67       0  100.00%
R/pivot.R                 73       0  100.00%
R/propagate.R             22       0  100.00%
R/reformat.R              73      21  71.23%   137-162, 202, 208
R/rules.R                 31       6  80.65%   69-74
R/utils.R                 29       1  96.55%   77
TOTAL                    447      29  93.51%

Results for commit: e9c7fee

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Unit Tests Summary

    1 files    11 suites   6s ⏱️
  58 tests   55 ✔️ 3 💤 0
184 runs  180 ✔️ 4 💤 0

Results for commit 3f8b340.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
rules 👶 $+0.02$ list2rules_fails_as_expected
rules 👶 $+0.03$ list2rules_works_as_expected

Results for commit e9c7fee

♻️ This comment has been updated with latest results.

Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@BFalquet BFalquet merged commit 7d48baa into main Mar 8, 2023
@BFalquet BFalquet deleted the 61-create-list2rules@main branch March 8, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants