-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
173 fix refactor adex@main #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Results for commit: 18df990 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
ayogasekaram
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @Melkiades
I would double check the -1 relative date. Other than that, everything appears to work well.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This PR needs a lot of care in its review. The execution gives an error in tests that I can not reproduce. It is potentially necessary to reconvert the date formats into simple characters or system base date, it depends on how
adex
is used downstream. I was just checking the difference in the cache and the new data set seems way too distant from the original cashed-data. I will explore these better tomorrow morning! I want to highlight that this is a hotfix and I will tomorrow write down some new issues to fix ADSL times before this one (which is only modified at the last stage). I am sure there are better ways to modify the data set, and any idea is super welcome!For some background on the new variables, I copy here my notes, that I took from talking with @malexthorpe.
Fixes #173