Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADPC and ADAB refactor #219

Merged
merged 28 commits into from
Nov 11, 2022
Merged

ADPC and ADAB refactor #219

merged 28 commits into from
Nov 11, 2022

Conversation

legrasv
Copy link
Contributor

@legrasv legrasv commented Nov 11, 2022

ADAB: Make it match with ADPC + ATACHAR variable
ADPC refactoring
#212

@shajoezhu shajoezhu added the sme label Nov 11, 2022
shajoezhu
shajoezhu requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @legrasv , can you recompile the cadab and cadpc data and make another commit

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022 •
edited

badge

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------------------------------------------------------------------
R/radab.R          222     222  0.00%    51-300
R/radae.R          199       3  98.49%   81, 100, 293
R/radaette.R       211       4  98.10%   51, 72, 78, 270
R/radcm.R          151      27  82.12%   52, 168-194, 206
R/raddv.R           91       3  96.70%   41, 55, 139
R/radeg.R          271       1  99.63%   372
R/radex.R          232       1  99.57%   329
R/radhy.R          136       1  99.26%   197
R/radlb.R          321       1  99.69%   417
R/radmh.R           94       2  97.87%   47, 137
R/radpc.R           75       1  98.67%   116
R/radpp.R           81       1  98.77%   149
R/radqs.R          107       1  99.07%   172
R/radrs.R          121       3  97.52%   48, 55, 184
R/radsaftte.R        1       1  0.00%    17
R/radsl.R          193       1  99.48%   270
R/radsub.R         142       1  99.30%   246
R/radtr.R          126       0  100.00%
R/radtte.R         143       4  97.20%   52, 72, 84, 190
R/radvs.R          160       1  99.38%   229
R/utils.R          154      59  61.69%   9-12, 56-59, 111-112, 117-118, 155-156, 214, 264, 266, 295-301, 305, 338-408, 466, 470
TOTAL             3231     338  89.54%

Diff against main

Filename      Stmts  Miss    Cover
----------  -------  ------  -------
R/radab.R        +5  +5      -
R/radpc.R        +2  -       +0.04%
TOTAL            +7  +5      -0.13%

Results for commit: bba546c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022 •
edited

Unit Tests Summary

  1 files    1 suites   27s ⏱️
23 tests 23 ✔️ 0 💤 0 ❌
91 runs  91 ✔️ 0 💤 0 ❌

Results for commit de2fdb3.

♻️ This comment has been updated with latest results.

shajoezhu and others added 13 commits November 11, 2022 12:42
@shajoezhu shajoezhu mentioned this pull request Nov 11, 2022
Closed
@shajoezhu shajoezhu enabled auto-merge (squash) November 11, 2022 13:43
shajoezhu
shajoezhu approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm!

@shajoezhu shajoezhu merged commit 4f8d1eb into main Nov 11, 2022
@shajoezhu shajoezhu deleted the 212refactorADAB@main branch November 11, 2022 13:44
@shajoezhu shajoezhu mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legrasv @shajoezhu