Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing values in key_cols under rlistings::as_listing() #157

Closed
qiliu1013 opened this issue Sep 23, 2023 · 0 comments · Fixed by #158
Closed

Missing values in key_cols under rlistings::as_listing() #157

qiliu1013 opened this issue Sep 23, 2023 · 0 comments · Fixed by #158
Assignees
Labels
bug Something isn't working enhancement New feature or request sme

Comments

@qiliu1013
Copy link

qiliu1013 commented Sep 23, 2023

Not Sure if these have been resolved, below are the improvement you may consider.

  • rlistings::as_listing() cannot handle if there were missing values in the variables that listed in key_col. The error message is not readable.
    Error in h(simpleError(msg, call)) : error in evaluating the argument 'x' in selecting a method for function 'toString': values must be length 1, but FUN(X[[1]]) result is length 0

  • fmt_config() doesn't work for character. Related to above issue, it doesn't work if na_str = "<No data>" was needed in charater variables that required in the listings.
    `

packageVersion("rlistings")
[1] ‘0.2.4’
`

Hi @shajoezhu, above are the issues we found when we test TLGc - PKCL01. It can be resolved if we do some data pre-processing, but the error message is confusing if we don't have this background info.

@qiliu1013 qiliu1013 added bug Something isn't working sme enhancement New feature or request labels Sep 23, 2023
@edelarua edelarua self-assigned this Sep 27, 2023
edelarua added a commit that referenced this issue Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants