Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes from fork PR for truetype font #214

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Changes from fork PR for truetype font #214

merged 5 commits into from
Jun 4, 2024

Conversation

Melkiades
Copy link
Contributor

See #211

@Melkiades Melkiades added enhancement New feature or request sme collab labels Jun 4, 2024
@Melkiades Melkiades mentioned this pull request Jun 4, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        29       5  82.76%   81-86
R/rlistings_methods.R      117      26  77.78%   18-29, 49, 65, 69, 155-158, 161, 245-251
R/rlistings.R              181      26  85.64%   159-162, 165-168, 176, 209-213, 385-388, 392-395, 424-427
TOTAL                      327      57  82.57%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/paginate_listing.R        -1       0  -0.57%
R/rlistings_methods.R      +16     +10  -6.38%
R/rlistings.R               +3       0  +0.24%
TOTAL                      +18     +10  -2.22%

Results for commit: 2c0df31

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

Unit Tests Summary

  1 files   5 suites   9s ⏱️
 37 tests 29 ✅  8 💤 0 ❌
104 runs  91 ✅ 13 💤 0 ❌

Results for commit 2c0df31.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@Melkiades
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Melkiades
Copy link
Contributor Author

recheck

@Melkiades
Copy link
Contributor Author

@ayogasekaram @shajoezhu @edelarua I need a review here! Thanks :)

edelarua
edelarua approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Melkiades Melkiades merged commit cbe712a into main Jun 4, 2024
28 checks passed
@Melkiades Melkiades deleted the 261_truetype_pag branch June 4, 2024 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edelarua edelarua edelarua approved these changes

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
collab enhancement New feature or request sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Melkiades @edelarua @gmbecker