Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow updates #107

Merged
merged 9 commits into from
Apr 19, 2023
Merged

Workflow updates #107

merged 9 commits into from
Apr 19, 2023

Conversation

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------------------------------
R/listing_export.R          58      11  81.03%   97, 132, 140-154
R/paginate_listing.R       103       5  95.15%   93, 98, 102, 105, 108
R/rlistings_methods.R       99      15  84.85%   23-24, 32, 47, 124, 130-133, 220-226
R/rlistings.R              130      12  90.77%   294-297, 301-304, 332-335
TOTAL                      390      43  88.97%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 4faa4a0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Unit Tests Summary

  1 files    4 suites   2s ⏱️
19 tests 19 ✔️ 0 💤 0
56 runs  56 ✔️ 0 💤 0

Results for commit d18b5d5.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @walkowif ! approve to unblock the PR.

@walkowif
Copy link
Contributor Author

Thanks @shajoezhu. We'll still have to wait with merging until the issues with verdepcheck action are resolved.

Copy link
Contributor

@insights-engineering-bot insights-engineering-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@walkowif walkowif merged commit 9fe7b8e into main Apr 19, 2023
@walkowif walkowif deleted the workflow-updates branch April 19, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants