Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing toString and pagination issues from export_txt and paginate_listings #109

Merged
merged 4 commits into from Apr 11, 2023
Merged

fixing toString and pagination issues from export_txt and paginate_listings #109

merged 4 commits into from Apr 11, 2023

Conversation

Melkiades
Copy link
Contributor

Fixes #108 and #106

@Melkiades Melkiades added bug Something isn't working sme labels Apr 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023 •
edited

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------------------------------
R/listing_export.R          58      11  81.03%   97, 132, 140-154
R/paginate_listing.R       103       5  95.15%   93, 98, 102, 105, 108
R/rlistings_methods.R       99      15  84.85%   23-24, 32, 47, 124, 130-133, 220-226
R/rlistings.R              130      12  90.77%   294-297, 301-304, 332-335
TOTAL                      390      43  88.97%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/listing_export.R           0      +2  -3.45%
R/paginate_listing.R        -2       0  -0.09%
R/rlistings_methods.R      -19      +3  -4.98%
TOTAL                      -21      +5  -1.78%

Results for commit: e70796e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023 •
edited

Unit Tests Summary

  1 files    4 suites   2s ⏱️
19 tests 19 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit a042d6e.

♻️ This comment has been updated with latest results.

insights-engineering-bot
insights-engineering-bot approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@insights-engineering-bot insights-engineering-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@gmbecker gmbecker merged commit b9fb852 into main Apr 11, 2023
23 checks passed
@gmbecker gmbecker deleted the 108_fix_printing@main branch April 11, 2023 20:22
This was referenced Apr 11, 2023
Closed
Closed
This was referenced Apr 11, 2023
Closed
Closed
@edelarua edelarua linked an issue Apr 11, 2023 that may be closed by this pull request
pagination for ael03 fails with default values #106
Closed
@Melkiades Melkiades mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insights-engineering-bot insights-engineering-bot insights-engineering-bot approved these changes

@gmbecker gmbecker Awaiting requested review from gmbecker

@edelarua edelarua Awaiting requested review from edelarua edelarua is a code owner

Assignees
No one assigned
Labels
bug Something isn't working sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpp and colwidths seems not working pagination for ael03 fails with default values
3 participants
@Melkiades @insights-engineering-bot @gmbecker