Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagination for ael03 fails with default values #106

Closed
Melkiades opened this issue Mar 20, 2023 · 4 comments · Fixed by #109
Closed

pagination for ael03 fails with default values #106

Melkiades opened this issue Mar 20, 2023 · 4 comments · Fixed by #109
Assignees
Labels
bug Something isn't working sme

Comments

@Melkiades
Copy link
Contributor

Failing test can be found in insightsengineering/scda.test#28

>   pg_lst <- paginate_listing(lst_res)
Error in paginate_listing(lst_res) : 
  Assertion on 'names(colwidths)' failed: Must be setequal to {'CPID','ASR','TRT01A','AEDECOD','Date_First','ASTDY','Duration','AESEV','Related','Outcome','Treated','Action','SERREAS'}, but has different type.
@edelarua
Copy link
Contributor

@Melkiades this should be fixed by insightsengineering/formatters#122, but other errors will then need to be resolved in the test for paginate_listing (can be fixed by setting other arguments, e.g. setting lpp = 30)

@gmbecker
Copy link
Contributor

gmbecker commented Mar 21, 2023

@shajoezhu this is why we need to realistic tests in the actual package tests, because formatters and rlistings (as of now) still both have a clean tst battery, and the failures are only happening in the downstream package.

This removes the core protection that CI is intended to provide (ie PRs can't even get merged if they cause test failures), to the detriment of the project as a whole

@shajoezhu
Copy link
Collaborator

I would be more than happy to include these more realistic tests in rlistings and formatters, in fact I proposed this initially last year, and that was why I placed one of the listing test in rlistings if you remember.

@gmbecker
Copy link
Contributor

Fixed in #109, @Melkiades please confirm and reopen if that test continues to fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sme
Projects
None yet
4 participants