New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pagination for ael03 fails with default values #106
Comments
@Melkiades this should be fixed by insightsengineering/formatters#122, but other errors will then need to be resolved in the test for |
@shajoezhu this is why we need to realistic tests in the actual package tests, because formatters and rlistings (as of now) still both have a clean tst battery, and the failures are only happening in the downstream package. This removes the core protection that CI is intended to provide (ie PRs can't even get merged if they cause test failures), to the detriment of the project as a whole |
I would be more than happy to include these more realistic tests in rlistings and formatters, in fact I proposed this initially last year, and that was why I placed one of the listing test in rlistings if you remember. |
Fixed in #109, @Melkiades please confirm and reopen if that test continues to fail |
Failing test can be found in insightsengineering/scda.test#28
The text was updated successfully, but these errors were encountered: