Allow page splitting by parameter in pagination

[edelarua]

Closes #153

Merge after insightsengineering/formatters#212

[github-actions]

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        30       5  83.33%   81-86
R/rlistings_methods.R      101      16  84.16%   24-25, 39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              178      26  85.39%   162-165, 168-171, 179, 212-216, 390-393, 397-400, 433-436
TOTAL                      309      47  84.79%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/paginate_listing.R       -17      +4  -14.54%
R/rlistings_methods.R        0      +2  -1.98%
R/rlistings.R              +12      +1  +0.45%
TOTAL                       -5      +7  -2.47%

Results for commit: 2957e3b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   5 suites   8s ⏱️
 37 tests 29 ✅  8 💤 0 ❌
104 runs  91 ✅ 13 💤 0 ❌

Results for commit 2957e3b.

♻️ This comment has been updated with latest results.

[shajoezhu]

raised again by @BFalquet , @khatril perhaps, we can consider merge this in

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
matrix_form	👶		$+0.20$	$+10$	$0$	$0$	$0$
paginate_listing	💔	$2.75$	$+2.05$	$+4$	$+1$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
export	👶		$+0.48$	export_as_txt_works_with_split_into_pages_by_var
listings	👶		$+0.03$	split_into_pages_by_var_works_as_expected
matrix_form	👶		$+0.21$	matrix_form_keeps_relevant_information_and_structure_about_the_listing
paginate_listing	💀	$0.02$	$-0.02$	defunct_is_defunct
paginate_listing	👶		$+0.18$	paginate_listing_works_with_split_into_pages_by_var

Results for commit 8248478

♻️ This comment has been updated with latest results.

[edelarua]

@Melkiades it's looking good! I think it works well, thanks for all the work you've done so far!! :)

I'm also not sure what the best name would be - maybe ask around and see what people think?

[shajoezhu]

split_into_pages_by_var ssounds better, and people would understand

[Melkiades]

@pawelru forgot to up the value of {formatters} sorry! I think we can have it in with next PR?

[pawelru]

@pawelru forgot to up the value of {formatters} sorry! I think we can have it in with next PR?

yes please - the sooner the better