Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vec_nlines and complete support newline character #167

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix vec_nlines and complete support newline character #167

merged 2 commits into from
Oct 17, 2023

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades added bug Something isn't working enhancement New feature or request sme labels Oct 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023 •
edited
Loading

Unit Tests Summary

  1 files    4 suites   4s ⏱️
30 tests 23 ✔️ 7 💤 0 ❌
75 runs  66 ✔️ 9 💤 0 ❌

Results for commit 00bde3c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              159      20  87.42%   156-157, 160-161, 200-202, 366-369, 373-376, 405, 409-412
TOTAL                      307      35  88.60%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/rlistings_methods.R       -6       0  -0.78%
TOTAL                       -6       0  -0.22%

Results for commit: 00bde3c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu shajoezhu marked this pull request as draft October 16, 2023 02:43
@shajoezhu
Copy link
Collaborator

hi @Melkiades , thanks for the change, blocking the PR before preparing for the new release

@Melkiades Melkiades marked this pull request as ready for review October 16, 2023 08:36
Melkiades
Melkiades commented Oct 16, 2023
View reviewed changes
R/rlistings_methods.R
mtchs <- gregexpr("\n", strvec, fixed = TRUE) # this was and is never seeing a \n
line_extension_count + vapply(mtchs, function(vi) sum(vi > 0), 1L)
# in formatters for characters
unlist(lapply(format_colvector(colvec = vec), nlines, max_width = max_width))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shajoezhu I think this fix is important to have

edelarua
edelarua approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Davide - this is a nice change :)

@shajoezhu shajoezhu enabled auto-merge (squash) October 17, 2023 01:59
@shajoezhu shajoezhu merged commit 5258875 into main Oct 17, 2023
46 checks passed
@shajoezhu shajoezhu deleted the add_tests@208_support_for_newline@main branch October 17, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua edelarua approved these changes

@insights-engineering-bot insights-engineering-bot Awaiting requested review from insights-engineering-bot

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Melkiades @shajoezhu @edelarua