Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding tests to fix infinite loop and export_as_txt colwidths that were hidden #170

Merged
merged 4 commits into from
Oct 18, 2023
Merged

adding tests to fix infinite loop and export_as_txt colwidths that were hidden #170

merged 4 commits into from
Oct 18, 2023

Conversation

Melkiades
Copy link
Contributor

Fixes #750

@Melkiades Melkiades added bug Something isn't working sme labels Oct 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

Unit Tests Summary

  1 files    4 suites   5s ⏱️
31 tests 24 ✔️ 7 💤 0 ❌
79 runs  70 ✔️ 9 💤 0 ❌

Results for commit 1cc1259.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              159      20  87.42%   156-157, 160-161, 200-202, 366-369, 373-376, 405, 409-412
TOTAL                      307      35  88.60%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 1cc1259

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Melkiades
Melkiades commented Oct 17, 2023
View reviewed changes
tests/testthat/_snaps/print.md
Comment on lines 27 to -32
Descript
Unique ion
Subject Of
Identif Planned Continous
ier Arm Level
Biomarker
1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an important improvement coming from the pre-proc/compactification (if it is a word) of the string matrix before wrapping

@shajoezhu shajoezhu enabled auto-merge (squash) October 18, 2023 03:54
shajoezhu
shajoezhu approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Melkiades , unblock the merge for UAT

@shajoezhu shajoezhu merged commit 17d37f5 into main Oct 18, 2023
24 checks passed
@shajoezhu shajoezhu deleted the 169_fix_inf_loop@750_solve_nl_in_export_as_txt@main branch October 18, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

@edelarua edelarua Awaiting requested review from edelarua edelarua is a code owner

@insights-engineering-bot insights-engineering-bot Awaiting requested review from insights-engineering-bot

Assignees
No one assigned
Labels
bug Something isn't working priority sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Melkiades @shajoezhu