Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint, apply styler #175

Merged
merged 5 commits into from Oct 23, 2023
Merged

Fix lint, apply styler #175

merged 5 commits into from Oct 23, 2023

Conversation

edelarua
Copy link
Contributor

Closes #174

Very minor changes needed compared to formatters and rtables since indentation was already 2 spaces for the most part. Just a few changes so that everything is passing both styler and linter checks.

@edelarua edelarua added the sme label Oct 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              167      26  84.43%   158-161, 164-167, 206-210, 374-377, 381-384, 413, 417-420
TOTAL                      315      41  86.98%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  -------
R/rlistings.R       +8      +6  -2.99%
TOTAL               +8      +6  -1.62%

Results for commit: 5f4284a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    4 suites   7s ⏱️
31 tests 24 ✔️ 7 💤 0 ❌
79 runs  70 ✔️ 9 💤 0 ❌

Results for commit 5f4284a.

shajoezhu
shajoezhu approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks a lot @edelarua

@edelarua edelarua merged commit dda9a17 into main Oct 23, 2023
23 checks passed
@edelarua edelarua deleted the 174_fix_lint_styler@main branch October 23, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

@Melkiades Melkiades Awaiting requested review from Melkiades Melkiades is a code owner

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply styler to package and fix all lint
2 participants
@edelarua @shajoezhu