Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate pkgdown site favicon #186

Merged
merged 4 commits into from Dec 1, 2023
Merged

Generate pkgdown site favicon #186

merged 4 commits into from Dec 1, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Dec 1, 2023

Closes #185

@edelarua edelarua added the sme label Dec 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 374-377, 381-384, 417-420
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 646d40d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Unit Tests Summary

  1 files    4 suites   5s ⏱️
32 tests 25 ✔️ 7 💤 0 ❌
80 runs  71 ✔️ 9 💤 0 ❌

Results for commit 646d40d.

@edelarua edelarua enabled auto-merge (squash) December 1, 2023 22:06
shajoezhu
shajoezhu approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @edelarua ltgm!

@edelarua edelarua merged commit 2c1d40e into main Dec 1, 2023
24 checks passed
@edelarua edelarua deleted the 185_generate_favicon@main branch December 1, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

@Melkiades Melkiades Awaiting requested review from Melkiades Melkiades is a code owner

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate pkgdown site favicon
2 participants
@edelarua @shajoezhu