Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code of conduct and news #202

Merged
merged 6 commits into from Mar 7, 2024
Merged

Conversation

Melkiades
Copy link
Contributor

Fixes #188

@Melkiades Melkiades added documentation Improvements or additions to documentation sme labels Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 377-380, 384-387, 420-423
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 73c091b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Unit Tests Summary

 1 files   4 suites   5s ⏱️
34 tests 27 ✅  7 💤 0 ❌
86 runs  75 ✅ 11 💤 0 ❌

Results for commit 73c091b.

♻️ This comment has been updated with latest results.

@shajoezhu
Copy link
Collaborator

hi @Melkiades

can you add some words on using staged dependencies in the contirbution.md file too. thanks!

insightsengineering/rtables#803

@Melkiades
Copy link
Contributor Author

hi @Melkiades

can you add some words on using staged dependencies in the contirbution.md file too. thanks!

insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

README.md Outdated Show resolved Hide resolved
@shajoezhu
Copy link
Collaborator

hi @Melkiades
can you add some words on using staged dependencies in the contirbution.md file too. thanks!
insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

you are right, somehow i remembered wrong. I will close the issue in rtables too. Thanks for checking!

@shajoezhu
Copy link
Collaborator

hi @Melkiades
can you add some words on using staged dependencies in the contirbution.md file too. thanks!
insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

you are right, somehow i remembered wrong. I will close the issue in rtables too. Thanks for checking!

hi @Melkiades , actually, now i remembered, we need to add a sentence for contributors, on how to use staged.dependencies, and stop the downstream checks.

otherwise the installation is not smooth for getting the right branches. i think we will need to add this in all

formatters, rlistings, rtables and tern

@Melkiades
Copy link
Contributor Author

hi @Melkiades
can you add some words on using staged dependencies in the contirbution.md file too. thanks!
insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

you are right, somehow i remembered wrong. I will close the issue in rtables too. Thanks for checking!

hi @Melkiades , actually, now i remembered, we need to add a sentence for contributors, on how to use staged.dependencies, and stop the downstream checks.

otherwise the installation is not smooth for getting the right branches. i think we will need to add this in all

formatters, rlistings, rtables and tern

It is not super clear to me what you want to add; I would do it in a different PR once we have created the issues ^^

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @Melkiades lets merge this in, and get the staged.deps in a seperate issue

@Melkiades Melkiades merged commit 582788e into main Mar 7, 2024
24 checks passed
@Melkiades Melkiades deleted the add_CODE_OF_CONDUCT_and_news@main branch March 7, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding CODE_OF_CONDUCT.md
3 participants