Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables in Viewer are difficult to read #194

Closed
anajens opened this issue May 6, 2021 · 6 comments
Closed

Tables in Viewer are difficult to read #194

anajens opened this issue May 6, 2021 · 6 comments

Comments

@anajens
Copy link
Contributor

anajens commented May 6, 2021

I'm testing gabe_table_tree branch and noticed that the Viewer output looks different.

  • Columns are too crowded, there needs to be some cell padding
  • I think we need at least a line to separate the header from the body of the table so it's easier to read
    image

This is how it looks with rtables devel verison:
image

@gmbecker
Copy link
Collaborator

gmbecker commented May 6, 2021

Hmm, I don't know why this would be. @waddella has the viewer code been touched?

Anyway, thanks for the report, we will look into this.

@anajens
Copy link
Contributor Author

anajens commented May 6, 2021

Also the nice indentation in the header is lost:
image

image

@npaszty
Copy link

npaszty commented May 13, 2021

@gmbecker
in addition to these observations here is another permutation related to as_html().

From randomly generated data.
image

While not in the open source environment we also see some challenges when using in our shiny app framework. perhaps this also could be looked into.
image

@sorinvoicu
Copy link

From what I noticed, the html css classes are missing, hence the formatting is off...

@gmbecker
Copy link
Collaborator

@svoicugit was correct, this is a bug that was introduced during my work on #168, but that wasn't caught because I never use Viewer and we don't currently have any tests for as_html.

Luckily it was also a very easy fix. Things should work now in versions 0.3.7.006+ (pushed to devel).

@gmbecker gmbecker added this to ToDo in May - Jul 2021 via automation May 17, 2021
@gmbecker gmbecker moved this from ToDo to Done in May - Jul 2021 May 17, 2021
@anajens
Copy link
Contributor Author

anajens commented May 19, 2021

Thank you very much for the fix @gmbecker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants