Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top-left indentation is lost with Viewer or as_html #204

Closed
anajens opened this issue May 19, 2021 · 7 comments
Closed

top-left indentation is lost with Viewer or as_html #204

anajens opened this issue May 19, 2021 · 7 comments

Comments

@anajens
Copy link
Contributor

anajens commented May 19, 2021

Following fix for #194, this is still an issue.

The nice indentation in the header is lost when displaying rtables in the Viewer or as html:
image

image

Originally posted by @anajens in #194 (comment)

@gmbecker
Copy link
Collaborator

@anajens are you still seeing this issue with the fix for #194 in place?

@anajens
Copy link
Contributor Author

anajens commented May 25, 2021

@gmbecker yes this is happening after fix for #194.

R version 3.6.3 (2020-02-29)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Debian GNU/Linux 9 (stretch)

Matrix products: default
BLAS/LAPACK: /usr/lib/libopenblasp-r0.2.19.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C               LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8     LC_MONETARY=en_US.UTF-8    LC_MESSAGES=C             
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] rtables_0.3.7.0006 magrittr_2.0.1    

loaded via a namespace (and not attached):
[1] compiler_3.6.3  htmltools_0.4.0 tools_3.6.3     Rcpp_1.0.4.6    digest_0.6.25   rlang_0.4.9  

@anajens
Copy link
Contributor Author

anajens commented May 26, 2021

Just to add an example which is probably related:

tbl <- basic_table() %>%
  split_rows_by("ARMCD", label_pos = "topleft", split_label = "     XXX") %>%
  analyze("AGE") %>%
  build_table(ex_adsl)

Print looks OK

     XXX   all obs
------------------
ARM A             
  Mean      33.77 
ARM B             
  Mean      35.43 
ARM C             
  Mean      35.43 

In html spaces are ignored:
image

This is not a new issue. I checked back in the Dec 2020 release and the header indentation was not working there either.

@gmbecker
Copy link
Collaborator

gmbecker commented May 26, 2021 via email

@anajens anajens changed the title Header indentation is lost with Viewer or as_html top-left indentation is lost with Viewer or as_html May 26, 2021
@anajens
Copy link
Contributor Author

anajens commented May 26, 2021

It was not too noticeable in tables with 2 levels in the top-left. But with more levels it does make it difficult to read.

@gmbecker
Copy link
Collaborator

Apologies for it not being tagged (or mentioned in the NEWS file) but this is fixed in version 0.3.7.0007 as well. Please confirm that on your end and if not feel free to reopen @anajens.

@anajens
Copy link
Contributor Author

anajens commented Jun 2, 2021

Hi @gmbecker any chance the top-left header indentation can be aligned with the table row labels?

For example, the second split variable row labels (eg CHN) now seems to be aligned with the third split variable top-left header (Biomarker).
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants