-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic QC: final formatted rtable into computer readable format #308
Comments
Hi @imazubi, So there are a few different things here. FIirst off, the output of that csv (actually the path_enriched_df, its not related to writing the file) is bugged. My initial guess is that it has to do with the table only having one column, but I'm not sure yet. Regardless, that will get fixed. At a higher level, we do have comparison facilities for actual rtables TableTree objects, which (optionally) take structure/pathing into account, so if the QCer is using R, I think that would probably be a better approach. See Finally, Part of the roadmap for the work this year that @waddella and I have put together is pushing those comparison/QC funciontalities even further, so if that is a priority please let us know that. |
Acute problem with csv export should be fixed (with regression test) int he above commit. |
QCing tables has a number of aspects. For comparing For comparing different tables created with For a general QC framework to check consistency among many tables with overlapping results I would suggest to build a path based framework and then use Maybe a quick win would be if we also output formatted cells in |
Hi @waddella and @gmbecker, thanks for these comments. We will get back to you with some SAS table soon by the end of april. Let's keep in touch. |
There are issues with putting the counts in in a way that would be machine accessible, they would essentially have to be the first row of observations, which would muddy the waters a great deal in terms of format/meaning of the rest of them. The bottom line is that an rtable table is a much more information rich object than the tsv/csv format supports. I'm happy to see what we can do in this regard but it is important that understand the limitations of the target format here... |
Hi @gmbecker I see, and I totally agree that rtable table is a much more information rich object than the tsv/csv format supports. I was saying this as when QC-ing, the first thing folks check are the column counts. However, as said, I think to be able to output formatted cells in |
There are 3 things that I can think of that can happen here:
I see downsides to each of these approaches, to be honest, so figuring out what is the right thing to do here is going to take careful thinking and closer collaboration on this feature. |
@imazubi Revisiting this. Is this feature still something you need? If so, as I said in my last comment, we need to have some more discussion about exaclty what this feature would do. If not, I'd like to close the issue for now, please let me know |
@gmbecker I will get back to you next week. |
Hi @gmbecker .
I feel that at least having the opportunity of obtaining a formated rtable in the computer readable format would be a good starting step to one day, be able to do some programmatic QC by using rtables. What do you guys think? |
Hi @gmbecker, I realized that by using
|
@imazubi this is possible with |
Hi @gmbecker ,
I was wondering if there is a way to convert a final formatted rtable into a dataframe writeable in a computer readable format so that the QC can be easily done i.e by:
There are some tables (i.e AE tables) with a considerable size that makes the visual QC difficult. With the current csv output would not be possible to QC programmatically.
rtables is an incredible package and I believe the addition of this feature would be an amazing step forward to widely use the package in clinical trials.
The text was updated successfully, but these errors were encountered: