Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug for alt_counts_df split by NA_character_ or different number of levels #720

Closed
Melkiades opened this issue Aug 23, 2023 · 3 comments · Fixed by #721
Closed
Assignees
Labels
bug sme tests Something they are concerned to

Comments

@Melkiades
Copy link
Contributor

Melkiades commented Aug 23, 2023

We need to test these cases and catch bugs

    afun_tmp <- function(x, .alt_df_row, ...) mean(x)
    lyt_row <- basic_table() %>% split_rows_by("ARMCD") %>% analyze("BMRKR1", afun = afun_tmp)
    DM_tmp <- DM %>% mutate("ARMCD" = NA_character_)
    lyt_row %>% build_table(ex_adsl, alt_counts_df = DM_tmp)
@Melkiades Melkiades added bug tests Something they are concerned to sme labels Aug 23, 2023
@Melkiades Melkiades self-assigned this Aug 23, 2023
@shajoezhu
Copy link
Collaborator

hey @Melkiades , can you provide an example here. Thanks

@Melkiades
Copy link
Contributor Author

hey @Melkiades , can you provide an example here. Thanks

We need this fast so I am working already on a solution (just catching the error after the split)

@shajoezhu
Copy link
Collaborator

to confirm, this gives error

Error in names(answer) <- names1 :
'names' attribute [3] must be the same length as the vector [0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug sme tests Something they are concerned to
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants