Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding col split names and paths clearly to .spl_context #665

Merged
merged 60 commits into from
Aug 18, 2023

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Jun 26, 2023

Fixes #539 and #517

@Melkiades Melkiades linked an issue Jun 26, 2023 that may be closed by this pull request
@Melkiades Melkiades changed the title adding col split names and paths clearly adding col split names and paths clearly to .spl_context Jun 26, 2023
@Melkiades Melkiades marked this pull request as ready for review June 26, 2023 16:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               662      46  93.05%   24, 94, 96, 371, 447-448, 451, 590, 681, 763-764, 854, 856-857, 880-881, 901, 1080-1083, 1214, 1298-1299, 1358-1361, 1394-1395, 1401-1406, 1449, 1455, 1544, 1636, 1647, 1649-1650, 1653-1654, 1682, 1708-1709
R/as_html.R                     88       7  92.05%   7-12, 68
R/colby_constructors.R         489      17  96.52%   63, 106-107, 155-156, 202-203, 328, 341, 1101, 1178, 1321, 1357, 1376, 1396, 1415, 1562
R/compare_rtables.R             78      11  85.90%   95-96, 99-100, 113-114, 131, 150-151, 181, 185
R/format_rcell.R                12       0  100.00%
R/indent.R                      13       2  84.62%   39-40
R/index_footnotes.R             52       0  100.00%
R/make_split_fun.R              97      15  84.54%   22-25, 48-49, 51-52, 103, 106, 252, 254-255, 259-260, 276, 366
R/make_subset_expr.R           106      12  88.68%   26-35, 93-98, 131, 197, 208, 215
R/simple_analysis.R              5       1  80.00%   48
R/split_funs.R                 422      54  87.20%   131, 135, 140-145, 149, 159-161, 195-196, 313-316, 332-337, 407, 447, 461-462, 476, 532, 541-542, 544, 556, 596, 616, 775, 782, 807-808, 816-817, 819-820, 978-979, 990-993, 1056-1057, 1113-1114
R/summary.R                    187      20  89.30%   40, 84, 188, 195, 260-263, 273-274, 293-294, 399, 453-457, 485, 513
R/tree_accessors.R             798      74  90.73%   93, 210, 223, 240, 271, 281, 293, 385, 407-408, 662-666, 774, 788, 805, 846, 900-901, 933, 959, 991-995, 1042, 1104-1106, 1120, 1186, 1272-1273, 1291, 1305-1306, 1314, 1344, 1357-1360, 1378-1381, 1445, 1483, 1573, 1651, 1661, 1671, 1680, 1686, 1692-1695, 1973, 2250, 2344, 2426-2432, 2576, 2675, 2698-2726, 2738-2743
R/tt_afun_utils.R              345      25  92.75%   44, 146, 152, 160-169, 218, 229-230, 452, 459-460, 524-526, 545, 559-560
R/tt_compare_tables.R           65       4  93.85%   56, 170, 248, 251
R/tt_compatibility.R           413      50  87.89%   19, 137-138, 187, 191, 321-322, 325-328, 335, 338, 365, 371-372, 442, 484, 513, 531, 555-556, 596, 609-611, 680, 705-708, 717, 769, 775, 782-783, 887, 893, 919-931, 960-961
R/tt_dotabulation.R            881      59  93.30%   44, 62-63, 66, 71-72, 248, 250, 295, 317, 320-321, 368, 400-401, 429-430, 514, 639-641, 690, 693, 720-722, 731, 748-750, 755-756, 949, 952, 979, 1090-1091, 1252-1256, 1352, 1445-1453, 1469-1472, 1483, 1487, 1492, 1501, 1505
R/tt_export.R                  202      36  82.18%   47, 63, 104-105, 136, 175-177, 233-246, 398-399, 405, 448-454, 458-460, 556-557, 569
R/tt_from_df.R                   9       0  100.00%
R/tt_paginate.R                382      26  93.19%   47, 69, 100-105, 355, 456-457, 474-476, 619-620, 664-669, 733, 735, 744, 750, 753
R/tt_pos_and_access.R          519      37  92.87%   73, 75-76, 100, 152, 187-189, 234, 471, 473, 480, 486, 499, 508-509, 673, 684-686, 692-695, 723, 765-766, 776, 927-928, 976-1000, 1224, 1294
R/tt_showmethods.R             121      20  83.47%   47, 73-87, 138, 154-157, 163, 170, 172-174, 252-253
R/tt_sort.R                     76       3  96.05%   211-212, 218
R/tt_toString.R                325      23  92.92%   112, 305, 318, 327, 334, 336, 342-352, 435, 489, 495, 704-729
R/utils.R                       26       1  96.15%   132
R/validate_table_struct.R       75      11  85.33%   76-79, 88-89, 129, 137-138, 191-192
R/Viewer.R                      56       9  83.93%   51, 55, 65-68, 87-88, 118
TOTAL                         6504     563  91.34%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/00tabletrees.R               +38      +5  -0.38%
R/colby_constructors.R          +7       0  +0.05%
R/index_footnotes.R             +2       0  +100.00%
R/make_split_fun.R             +97     +15  +84.54%
R/split_funs.R                  +1      -1  +0.27%
R/summary.R                     +4      +4  -1.95%
R/tree_accessors.R              +5      +6  -0.70%
R/tt_dotabulation.R           +144     +15  -0.73%
R/tt_export.R                  -27     -37  +14.06%
R/tt_paginate.R                 -1     +11  -2.89%
R/tt_pos_and_access.R           -1       0  -0.01%
R/tt_showmethods.R               0      -1  +0.83%
R/tt_sort.R                     -5      -3  +3.46%
R/tt_toString.R                +20      +1  +0.14%
R/utils.R                      +15       0  +5.24%
R/validate_table_struct.R      +75     +11  +85.33%
TOTAL                         +374     +26  +0.10%

Results for commit: c95ece1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Unit Tests Summary

       1 files       24 suites   2m 0s ⏱️
   176 tests    176 ✔️ 0 💤 0
1 367 runs  1 367 ✔️ 0 💤 0

Results for commit c788fa6.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu mentioned this pull request Jul 26, 2023
19 tasks
R/colby_constructors.R Outdated Show resolved Hide resolved
R/colby_constructors.R Outdated Show resolved Hide resolved
R/colby_constructors.R Outdated Show resolved Hide resolved
R/colby_constructors.R Show resolved Hide resolved
R/colby_constructors.R Show resolved Hide resolved
R/tt_dotabulation.R Show resolved Hide resolved
R/tt_dotabulation.R Outdated Show resolved Hide resolved
R/tt_dotabulation.R Outdated Show resolved Hide resolved
tests/testthat/test-tab_afun_cfun.R Show resolved Hide resolved
tests/testthat/test-tab_afun_cfun.R Outdated Show resolved Hide resolved
R/colby_constructors.R Outdated Show resolved Hide resolved
R/tt_dotabulation.R Outdated Show resolved Hide resolved
R/tt_dotabulation.R Outdated Show resolved Hide resolved
R/tt_dotabulation.R Outdated Show resolved Hide resolved
@Melkiades Melkiades force-pushed the 539_add_to_spl_context@main branch from e560f84 to caf79e0 Compare July 28, 2023 15:04
@Melkiades
Copy link
Contributor Author

@gmbecker updated ;)

@Melkiades Melkiades requested a review from gmbecker August 3, 2023 10:09
Signed-off-by: Davide Garolini <davide.garolini@roche.com>
@Melkiades
Copy link
Contributor Author

@gmbecker

@Melkiades Melkiades requested review from gmbecker and removed request for edelarua, ayogasekaram and gmbecker August 15, 2023 11:18
@gmbecker gmbecker merged commit f015b4e into main Aug 18, 2023
17 checks passed
@gmbecker gmbecker deleted the 539_add_to_spl_context@main branch August 18, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants