Combine duplicate ref footnotes #781

edelarua · 2023-11-09T00:12:10Z

Closes #779

Merge after insightsengineering/formatters#225

github-actions · 2023-11-09T00:18:15Z

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               737      62  91.59%   22, 103, 106, 413, 497-498, 501, 656, 756, 847-848, 949, 951-952, 975-978, 1000, 1113-1116, 1211-1216, 1363, 1458-1461, 1524-1527, 1562-1565, 1571-1576, 1625, 1632, 1730, 1840, 1854, 1857-1860, 1863-1866, 1894, 1925-1926
R/as_html.R                    174      19  89.08%   74, 146-151, 156-161, 176-180, 268
R/colby_constructors.R         555      20  96.40%   71, 123, 181-184, 244-247, 387, 404, 1213, 1304, 1465, 1503, 1525, 1549, 1570, 1726
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 157-158, 189, 194
R/format_rcell.R                12       0  100.00%
R/indent.R                      13       2  84.62%   39-40
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             119      23  80.67%   22-25, 51-54, 57-60, 115, 119, 280, 283-286, 291-294, 313, 412
R/make_subset_expr.R           136      14  89.71%   34-48, 126-133, 168, 250, 266, 274
R/simple_analysis.R              5       1  80.00%   55
R/split_funs.R                 505      66  86.93%   143, 148, 154-159, 164, 181-185, 366-371, 388-393, 474, 526, 544-547, 564, 631, 641-642, 644, 658, 702, 727, 903, 910, 936-939, 950-951, 953, 955, 1126-1128, 1142-1146, 1210-1213, 1276-1279
R/summary.R                    215      24  88.84%   38, 85, 192, 200, 271-276, 287-288, 307-308, 418, 465-481, 516, 549
R/tree_accessors.R             857      93  89.15%   109, 251, 269, 292, 330, 344, 360, 465, 492-493, 774-779, 907, 925, 949, 999, 1054-1055, 1094, 1127, 1163-1167, 1220, 1295-1299, 1317-1327, 1396, 1501-1504, 1529, 1549-1550, 1559, 1600, 1618-1622, 1643-1647, 1726, 1768, 1872, 1976, 1989, 2002, 2016, 2024, 2033-2037, 2379, 2737, 2850, 2883-2905, 2994-3001, 3161, 3279, 3305-3339, 3355-3362
R/tt_afun_utils.R              411      32  92.21%   50, 164, 171, 181-194, 260, 271-272, 504, 512-515, 597-601, 622, 637-639
R/tt_compare_tables.R           70       4  94.29%   56, 178, 257, 261
R/tt_compatibility.R           510      56  89.02%   19, 142-143, 192, 197, 332-333, 337-340, 346, 350, 398, 520, 568, 601, 621, 654-657, 701, 718-722, 809, 837-840, 849, 912, 920, 931-934, 1044, 1051, 1080-1094, 1125-1126
R/tt_dotabulation.R           1116      96  91.40%   54, 252, 257, 259, 310, 334, 338-341, 373-376, 399, 434-437, 465-468, 564, 702-706, 757, 761, 790-793, 803, 823-827, 834-837, 1093, 1097, 1129, 1242-1245, 1439-1447, 1588, 1672-1681, 1761-1764, 1775, 1780, 1785-1786, 1788, 1799, 1804, 1827, 1922-1941
R/tt_export.R                  472      44  90.68%   48, 65, 105-109, 142, 181-185, 249-262, 365-368, 383, 711, 720, 745-749, 916-919, 922, 953, 959
R/tt_from_df.R                   9       0  100.00%
R/tt_paginate.R                436      37  91.51%   48, 73, 110-118, 393, 515-518, 538-542, 692-695, 745-752, 821, 824, 834, 841, 844
R/tt_pos_and_access.R          571      43  92.47%   77, 79-81, 106, 166, 212-216, 262, 514, 516, 524, 530, 544, 554-557, 739, 750-754, 759-762, 789, 842-843, 855, 1021-1022, 1080-1108, 1388, 1465
R/tt_showmethods.R             144      21  85.42%   60, 97-120, 183, 209, 218, 226, 229-233, 326-327
R/tt_sort.R                     88       5  94.32%   223-226, 234
R/tt_toString.R                393      25  93.64%   118, 309, 357, 372, 382, 389, 392, 398-408, 496, 561, 567, 802-828
R/utils.R                       23       0  100.00%
R/validate_table_struct.R       84      12  85.71%   79-83, 92-93, 140, 150-151, 204-205
R/Viewer.R                      61       9  85.25%   47, 51, 61-65, 85, 119
TOTAL                         7865     725  90.78%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/00tabletrees.R              +113     +21  -1.84%
R/as_html.R                    +86     +12  -2.96%
R/colby_constructors.R         +73      +3  -0.08%
R/compare_rtables.R             +5      +6  -6.38%
R/index_footnotes.R            +16       0  +100.00%
R/make_split_fun.R            +119     +23  +80.67%
R/make_subset_expr.R           +30      +2  +1.03%
R/split_funs.R                 +84     +11  -0.01%
R/summary.R                    +32      +8  -2.42%
R/tree_accessors.R             +64     +25  -2.28%
R/tt_afun_utils.R              +66      +7  -0.54%
R/tt_compare_tables.R           +5       0  +0.44%
R/tt_compatibility.R           +97      +6  +1.13%
R/tt_dotabulation.R           +379     +52  -2.63%
R/tt_export.R                 +243     -29  +22.56%
R/tt_paginate.R                +53     +22  -4.57%
R/tt_pos_and_access.R          +51      +6  -0.42%
R/tt_showmethods.R             +23       0  +2.77%
R/tt_sort.R                     +7      -1  +1.73%
R/tt_toString.R                +88      +3  +0.85%
R/utils.R                      +12      -1  +9.09%
R/validate_table_struct.R      +84     +12  +85.71%
R/Viewer.R                      +5       0  +1.32%
TOTAL                        +1735    +188  -0.46%

Results for commit: ba2e8f1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2023-11-09T00:27:43Z

Unit Tests Summary

      1 files     24 suites 1m 24s ⏱️
  190 tests   190 ✔️ 0 💤 0 ❌
1 432 runs 1 432 ✔️ 0 💤 0 ❌

Results for commit ba2e8f1.

♻️ This comment has been updated with latest results.

R/tt_toString.R

R/tree_accessors.R

Melkiades

Lgtm Emily!! Great work as always :)

Melkiades · 2023-11-14T16:08:12Z

R/tree_accessors.R

+    old = "col_fnotes_here<-",
+    msg = "col_fnotes_here<- was deprecated in {rtables} version 0.6.5.9011. Please use col_footnotes<- instead."
+  )
+  col_footnotes(obj) <- value


only a silly question: why dont we need here to have obj at the end while in other places we do?

I'm not sure, possibly accidental? I don't think these functions were ever fully fleshed out

edelarua added 9 commits November 7, 2023 20:55

No duplicate ref footnotes

15c2be4

test

0f31970

Collect and order ref footnotes for numbering

84db2b8

Account for column ref footnotes

01f67ce

Clean up

7cdf8dd

Add accessor for all tabletree column footnotes

84f83f6

Fix warnings from nested column footnotes

ab5ae25

return NULL from accessor if no col ref footnotes

49e9fad

Fix tests

9c8e248

edelarua added the sme label Nov 9, 2023

edelarua requested review from Melkiades and ayogasekaram as code owners November 9, 2023 00:12

Revert temp testing change

de9e893

Update NEWS

7162cb1

edelarua mentioned this pull request Nov 9, 2023

Refactor surv_time to enable cell footnotes insightsengineering/tern#1116

Merged

Melkiades reviewed Nov 9, 2023

View reviewed changes

R/tt_toString.R Show resolved Hide resolved

Melkiades reviewed Nov 9, 2023

View reviewed changes

R/tree_accessors.R Outdated Show resolved Hide resolved

Melkiades added 2 commits November 13, 2023 15:26

deprecating here

03acf7d

news

4ab950a

Melkiades reviewed Nov 13, 2023

View reviewed changes

R/tree_accessors.R Show resolved Hide resolved

edelarua added 4 commits November 13, 2023 11:46

Add test for pagination with referential footnotes

37f3ca9

Update test

33bf3dd

Order footnotes for matrix_form

2c3da57

Update tests

cceb39e

Melkiades reviewed Nov 14, 2023

View reviewed changes

R/tree_accessors.R Outdated Show resolved Hide resolved

Melkiades approved these changes Nov 14, 2023

View reviewed changes

edelarua added 2 commits November 14, 2023 10:58

Update deprecation

4ed8b26

Styler

51c09b2

Melkiades reviewed Nov 14, 2023

View reviewed changes

edelarua added 3 commits November 14, 2023 15:05

Merge branch 'main' into 779_duplicate_ref_fnotes@main

e2eb73e

Fix warning in integration tests

ae7a856

Update required formatters version

ba2e8f1

edelarua merged commit 5f19f73 into main Nov 23, 2023
17 checks passed

edelarua deleted the 779_duplicate_ref_fnotes@main branch November 23, 2023 20:07

edelarua mentioned this pull request Dec 6, 2023

Update snapshots with referential footnotes insightsengineering/scda.test#79

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Combine duplicate ref footnotes #781

Combine duplicate ref footnotes #781

edelarua commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

Melkiades left a comment

Melkiades Nov 14, 2023

edelarua Nov 14, 2023

Combine duplicate ref footnotes #781

Combine duplicate ref footnotes #781

Conversation

edelarua commented Nov 9, 2023 • edited Loading

github-actions bot commented Nov 9, 2023 • edited Loading

Code Coverage Summary

Diff against main

github-actions bot commented Nov 9, 2023 • edited Loading

Unit Tests Summary

Melkiades left a comment

Choose a reason for hiding this comment

Melkiades Nov 14, 2023

Choose a reason for hiding this comment

edelarua Nov 14, 2023

Choose a reason for hiding this comment

edelarua commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading