Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce the amount of spelling issues / WORDLIST #221

Merged
merged 6 commits into from
Jun 30, 2023
Merged

reduce the amount of spelling issues / WORDLIST #221

merged 6 commits into from
Jun 30, 2023

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jun 27, 2023 •
edited
Loading

The follow-up after https://github.com/insightsengineering/coredev-tasks/issues/235

Final spelling::spell_check_package() output:

Main spelling issues are surnames or github nicknames and words in DESCRIPTION file that can not be omitted anyway

  WORD               FOUND IN
ADaM               description:5
ADLB               description:6
ADSL               description:6
balazs             tm_g_gh_boxplot.Rd:254
                   tm_g_gh_correlationplot.Rd:330
                   tm_g_gh_density_distribution_plot.Rd:196
                   tm_g_gh_lineplot.Rd:226
                   tm_g_gh_scatterplot.Rd:199
                   tm_g_gh_spaghettiplot.Rd:269
Balazs             tm_g_gh_boxplot.Rd:254
                   tm_g_gh_correlationplot.Rd:330
                   tm_g_gh_density_distribution_plot.Rd:196
                   tm_g_gh_lineplot.Rd:226
                   tm_g_gh_scatterplot.Rd:199
                   tm_g_gh_spaghettiplot.Rd:269
biomarker          teal_goshawk.Rd:8
                   tm_g_gh_boxplot.Rd:42,46
                   tm_g_gh_correlationplot.Rd:51,53,55,57,59
                   tm_g_gh_density_distribution_plot.Rd:36,38,40
                   tm_g_gh_lineplot.Rd:47,49
                   tm_g_gh_scatterplot.Rd:38,40,42,44
                   tm_g_gh_spaghettiplot.Rd:46,48
                   user-guide.Rmd:20,44,47,65,67
Biomarker          tm_g_gh_correlationplot.Rd:5,126
                   tm_g_gh_scatterplot.Rd:5
biomarkers         tm_g_gh_boxplot.Rd:44
                   user-guide.Rmd:44
Biomarkers         user-guide.Rmd:47
customizable       data-expectations.Rmd:20
                   teal-goshawk.Rmd:29
facetting          NEWS.md:162
Forkers            README.md:49,59,61
interpretability   data-expectations.Rmd:138
jeffrey            tm_g_gh_boxplot.Rd:252
liu                tm_g_gh_lineplot.Rd:224
                   tm_g_gh_spaghettiplot.Rd:267
LOQFL              description:7
luiw               tm_g_gh_lineplot.Rd:224
                   tm_g_gh_spaghettiplot.Rd:267
minmax             toggle_slider_ui.Rd:54
nicholas           tm_g_gh_correlationplot.Rd:328
                   tm_g_gh_density_distribution_plot.Rd:194
                   tm_g_gh_scatterplot.Rd:197
npaszty            tm_g_gh_correlationplot.Rd:328
                   tm_g_gh_density_distribution_plot.Rd:194
                   tm_g_gh_scatterplot.Rd:197
paszty             tm_g_gh_correlationplot.Rd:328
                   tm_g_gh_density_distribution_plot.Rd:194
                   tm_g_gh_scatterplot.Rd:197
pre                maptrt.Rd:18
                   tm_g_gh_boxplot.Rd:55
                   tm_g_gh_correlationplot.Rd:61
                   tm_g_gh_density_distribution_plot.Rd:42
                   tm_g_gh_lineplot.Rd:66
                   tm_g_gh_scatterplot.Rd:46
                   tm_g_gh_spaghettiplot.Rd:66
                   teal-goshawk.Rmd:109
repo               README.md:9,15,57,61
roche              tm_g_gh_boxplot.Rd:252
                   tm_g_gh_lineplot.Rd:224
                   tm_g_gh_spaghettiplot.Rd:267
toggleable         toggle_slider_ui.Rd:5
                   NEWS.md:155
tomlinsj           tm_g_gh_boxplot.Rd:252
tomlinson          tm_g_gh_boxplot.Rd:252
tooltip            NEWS.md:8
toth               tm_g_gh_boxplot.Rd:254
                   tm_g_gh_correlationplot.Rd:330
                   tm_g_gh_density_distribution_plot.Rd:196
                   tm_g_gh_lineplot.Rd:226
                   tm_g_gh_scatterplot.Rd:199
                   tm_g_gh_spaghettiplot.Rd:269
tothb              tm_g_gh_boxplot.Rd:254
                   tm_g_gh_correlationplot.Rd:330
                   tm_g_gh_density_distribution_plot.Rd:196
                   tm_g_gh_lineplot.Rd:226
                   tm_g_gh_scatterplot.Rd:199
                   tm_g_gh_spaghettiplot.Rd:269
UI                 srv_arbitrary_lines.Rd:11
                   teal_goshawk.Rd:8
                   tm_g_gh_boxplot.Rd:103
                   tm_g_gh_density_distribution_plot.Rd:78
                   tm_g_gh_lineplot.Rd:120
                   tm_g_gh_spaghettiplot.Rd:119
                   toggle_slider_ui.Rd:5,44
                   ui_arbitrary_lines.Rd:5,36
                   NEWS.md:7,51,122,131,156
wenyi              tm_g_gh_lineplot.Rd:224
                   tm_g_gh_spaghettiplot.Rd:267

@m7pr m7pr added documentation Improvements or additions to documentation core labels Jun 27, 2023
@m7pr m7pr mentioned this pull request Jun 28, 2023
Closed
10 tasks
@m7pr m7pr marked this pull request as ready for review June 28, 2023 08:29
@m7pr m7pr requested a review from a team June 28, 2023 08:29
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        349     349  0.00%    218-634
R/tm_g_gh_correlationplot.R                552     552  0.00%    285-943
R/tm_g_gh_density_distribution_plot.R      274     274  0.00%    163-486
R/tm_g_gh_lineplot.R                       559     559  0.00%    186-839
R/tm_g_gh_scatterplot.R                    235     235  0.00%    169-455
R/tm_g_gh_spaghettiplot.R                  284     284  0.00%    228-578
R/toggleable_slider.R                      154     154  0.00%    82-253
R/utils-arbitrary_lines.r                  121     121  0.00%    19-172
R/utils-data_constraints.r                 186     186  0.00%    2-255
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    26-38
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   17      17  0.00%    12-32
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2812    2812  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d0c682d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr requested a review from pawelru June 29, 2023 08:53
@m7pr m7pr merged commit 43d0a8c into main Jun 30, 2023
26 checks passed
@m7pr m7pr deleted the update_wordlist@main branch June 30, 2023 08:05
@m7pr m7pr mentioned this pull request Jul 11, 2023
Merged
m7pr added a commit that referenced this pull request Jul 12, 2023
@m7pr
216 update teal.code version in dependencies (#224)
04bee95 
Closes #216 

qenv replaced chunks in this PR
https://github.com/insightsengineering/teal.goshawk/pull/203/files -
this is a backend change and this was not exposed in vignettes and not
exposed in examples. I reviewed examples and vignettes in the last 2
weeks while working on #223 and #221 and I run those examples multiple
times recently. Most of the things marked in #216 were not needed to be
checked, besides the teal.code version bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelru pawelru pawelru approved these changes

Assignees
No one assigned
Labels
core documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m7pr @pawelru