-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
222 decouple scda #223
Merged
Merged
222 decouple scda #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Diff against main
Results for commit: edb7eb4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
gogonzo
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace NEWS entry
# Examples now use `scda.2022` data instead of `scda.2021`.
There is also recommendation to install scda in README. You can remove this also. Please look for the same line in goshawk's README
m7pr
added a commit
that referenced
this pull request
Jul 12, 2023
m7pr
added a commit
that referenced
this pull request
Jul 12, 2023
Closes #216 qenv replaced chunks in this PR https://github.com/insightsengineering/teal.goshawk/pull/203/files - this is a backend change and this was not exposed in vignettes and not exposed in examples. I reviewed examples and vignettes in the last 2 weeks while working on #223 and #221 and I run those examples multiple times recently. Most of the things marked in #216 were not needed to be checked, besides the teal.code version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222
Also needed to remove it from scda and scda.2022 packages insightsengineering/scda#127 insightsengineering/scda.2022#126