222 decouple scda #223

m7pr · 2023-07-11T11:13:59Z

Fixes #222

Also needed to remove it from scda and scda.2022 packages insightsengineering/scda#127 insightsengineering/scda.2022#126

github-actions · 2023-07-11T11:26:18Z

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        349     349  0.00%    216-632
R/tm_g_gh_correlationplot.R                552     552  0.00%    282-940
R/tm_g_gh_density_distribution_plot.R      274     274  0.00%    161-484
R/tm_g_gh_lineplot.R                       559     559  0.00%    184-837
R/tm_g_gh_scatterplot.R                    235     235  0.00%    167-453
R/tm_g_gh_spaghettiplot.R                  284     284  0.00%    227-577
R/toggleable_slider.R                      154     154  0.00%    82-253
R/utils-arbitrary_lines.r                  121     121  0.00%    19-172
R/utils-data_constraints.r                 186     186  0.00%    2-255
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    25-37
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   17      17  0.00%    12-32
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2812    2812  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: edb7eb4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

gogonzo

Please replace NEWS entry

# Examples now use `scda.2022` data instead of `scda.2021`.

There is also recommendation to install scda in README. You can remove this also. Please look for the same line in goshawk's README

Missed in #223

Closes #216 qenv replaced chunks in this PR https://github.com/insightsengineering/teal.goshawk/pull/203/files - this is a backend change and this was not exposed in vignettes and not exposed in examples. I reviewed examples and vignettes in the last 2 weeks while working on #223 and #221 and I run those examples multiple times recently. Most of the things marked in #216 were not needed to be checked, besides the teal.code version bump.

decouple scda

8a5d306

m7pr added the core label Jul 11, 2023

m7pr requested a review from a team July 11, 2023 11:54

m7pr mentioned this pull request Jul 11, 2023

216 update teal.code version in dependencies #224

Merged

gogonzo approved these changes Jul 11, 2023

View reviewed changes

gogonzo self-assigned this Jul 11, 2023

m7pr merged commit ab6bfe9 into main Jul 12, 2023
24 checks passed

m7pr deleted the 222_decouple_scda@main branch July 12, 2023 07:29

m7pr mentioned this pull request Jul 12, 2023

remove scda from NEWS and README #225

Merged

m7pr added a commit that referenced this pull request Jul 12, 2023

remove scda from NEWS and README (#225)

bbe7d69

Missed in #223

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

222 decouple scda #223

222 decouple scda #223

m7pr commented Jul 11, 2023

github-actions bot commented Jul 11, 2023

gogonzo left a comment •

edited

Loading

222 decouple scda #223

222 decouple scda #223

Conversation

m7pr commented Jul 11, 2023

github-actions bot commented Jul 11, 2023

Code Coverage Summary

Diff against main

gogonzo left a comment • edited Loading

Choose a reason for hiding this comment

gogonzo left a comment •

edited

Loading