Date and DateTime invalid ranges crashes app

[nikolas-burkoff]

From #155 (review)

Change date or date time so that the "from" is after "to":

And the app crashes:

library(teal)
library(scda)

adsl <- synthetic_cdisc_dataset("latest", "adsl")

app <- init(
  data = teal_data(dataset("ADSL", adsl)),
  modules = example_module()
)

runApp(app)

This should be fixed alongside #133 when there is a "save" button to enable validation of filter panel inputs.

Please also add tests

[nikolas-burkoff]

See #133 (comment) for example shinyvalidate with these widgets

[donyunardi]

Should we consider changing the airDatepickerInput to dateRangeInput?

teal.slice/R/FilterStateDatettime.R

Lines 207 to 244 in aab1255

	div(
	class = "flex w-80 filter_datelike_input",
	div(class = "w-45 text-center", {
	x <- shinyWidgets::airDatepickerInput(
	inputId = ns("selection_start"),
	value = self$get_selected()[1],
	startView = self$get_selected()[1],
	timepicker = TRUE,
	minDate = private$choices[1],
	maxDate = private$choices[2],
	update_on = "close",
	addon = "none",
	position = "bottom right"
	)
	x$children[[2]]$attribs <- c(x$children[[2]]$attribs, list(class = "input-sm"))
	x
	}),
	span(
	class = "input-group-addon w-10",
	span(class = "input-group-text w-100 justify-content-center", "to"),
	title = "Times are displayed in the local timezone and are converted to UTC in the analysis"
	),
	div(class = "w-45 text-center", {
	x <- shinyWidgets::airDatepickerInput(
	inputId = ns("selection_end"),
	value = self$get_selected()[2],
	startView = self$get_selected()[2],
	timepicker = TRUE,
	minDate = private$choices[1],
	maxDate = private$choices[2],
	update_on = "close",
	addon = "none",
	position = "bottom right"
	)
	x$children[[2]]$attribs <- c(x$children[[2]]$attribs, list(class = "input-sm"))
	x
	})
	),

Here's an example where user has to pick an end date greater than start date.
This way, we don't need to add any validation to check the date ranges.

This could be along the line when @asbates mentioned about observeEvent today.

library(shiny)
ui <- fluidPage(
  dateRangeInput("date_range", "Input date range", start = "2001-01-01", end = "2001-02-01")
)

server <- function(input, output, session) {
    observeEvent(input$date_range[1], {
        end_date = input$date_range[2]
        if (input$date_range[2] < input$date_range[1]) {
            end_date = input$date_range[1]
        }        
        updateDateRangeInput(session, "date_range",
        label = "Date range",
        start = input$date_range[1],
        end = end_date,
        min = input$date_range[1]
        )
    })
}

shinyApp(ui, server)

[donyunardi]

Acceptance Criteria:

• Create a flow to prevent user to pick a start date < end date