Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: FilterState to not show shiny inputs by default #129

Closed
Tracked by #81 ...
gogonzo opened this issue Nov 23, 2022 · 1 comment · Fixed by #155 or #195
Closed
Tracked by #81 ...

[Feature Request]: FilterState to not show shiny inputs by default #129

gogonzo opened this issue Nov 23, 2022 · 1 comment · Fixed by #155 or #195
Assignees
Labels
core enhancement New feature or request

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Nov 23, 2022

part of #48

Feature description

Please see the wireframe

  1. Shiny inputs should not be visible by default. So called filter-card-summary (ui of the FilterState) should displayed - showing summarized information of the filer-state.
  2. User clicks the active button in filter-card-summary to trigger change from filter-card-summary to filter-card-interactive. (Button can be a small gear icon or the card itself).
  3. filter-card-interactive is rendered each time it's triggered to show (selection is based on the current state). User can change the values in filter-card-interactive and they are not propagated immediately until one clicks save. Once saved card turns back again to filter-card-summary with a new values. Thanks to updating values of the interactive selection after save only, we don't need a set_selected_reactive anymore (please see below).

Important: Please be aware of how the FilterState$private$selected can be changed. Please see help(teal.slice:::FilterState) and go to the modyfying state, you'll see following image:

image

Filter states can be changed in three ways. See example FilterState$server:

  • In the interactive session by directly specifying values of selected, keep_na or keep_inf using set_state method (to update all at once), or using set_selected, set_keep_na or set_keep_inf
  • In a teal application by changing appropriate inputs
  • Using methods set_selected_reactive, set_keep_na_reactive, set_keep_inf_reactive which serves as a programmatic API.

Important improvement would be to remove area in the dashed rectangle which will simplify this process.

@nikolas-burkoff
Copy link
Contributor

If this issue involves adding a "save" button to apply the filters then: #133 and #158 should also be done with this

@gogonzo gogonzo reopened this Jan 13, 2023
@gogonzo gogonzo assigned asbates and unassigned gogonzo Jan 19, 2023
@donyunardi donyunardi linked a pull request Feb 13, 2023 that will close this issue
gogonzo added a commit that referenced this issue Feb 14, 2023
Allows filter state inputs to collapse and expand, defaulting to
collapsed. Only 1 filter state per data set can be open at a time.

- For a given data set, filter information is in an accordion of
collapsible cards
- Only 1 filter state (per data set) can be open at a time.
- Card headers show a summary of the filter state.

Logical and choices filter state UIs don't display correctly, at least
on Bootstrap 4.


Closes #129.

---------

Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
@asbates asbates closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment