Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend format/print for all classes with trim_lines argument #378

Closed
3 tasks done
m7pr opened this issue Jul 10, 2023 · 0 comments · Fixed by #379
Closed
3 tasks done

Extend format/print for all classes with trim_lines argument #378

m7pr opened this issue Jul 10, 2023 · 0 comments · Fixed by #379
Assignees
@m7pr
Labels
core enhancement New feature or request

Comments

@m7pr
Copy link
Contributor

m7pr commented Jul 10, 2023

Feature description

After we introduced #339 we allowed teal_slice and teal_slices objects to have a trim_lines parameter in their S3 generic methods for print and format. This should also be extended in FilterState/FilterStates classed

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@m7pr m7pr added enhancement New feature or request core labels Jul 10, 2023
@m7pr m7pr self-assigned this Jul 10, 2023
m7pr added a commit that referenced this issue Jul 10, 2023
@m7pr
fix #378
c116777
@m7pr m7pr mentioned this issue Jul 10, 2023
Merged
m7pr added a commit that referenced this issue Jul 10, 2023
@m7pr @chlebowa @dependabot-preview
378 trim_lines parameter in format (#379)
7c5dc53 
Closes #378 

This PR provides an ability to pass `trim_lines` parameter for
`$format()` method of FilterState, FilerStates, FilteredDataset and
FilteredData R6 objects.

---------

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@m7pr m7pr closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m7pr m7pr

Labels
core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

378 trim_lines parameter in format insightsengineering/teal.slice
1 participant
@m7pr