Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

378 trim_lines parameter in format #379

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jul 10, 2023

Closes #378

This PR provides an ability to pass trim_lines parameter for $format() method of FilterState, FilerStates, FilteredDataset and FilteredData R6 objects.

@m7pr m7pr added the core label Jul 10, 2023
@m7pr m7pr requested a review from chlebowa July 10, 2023 11:09
@m7pr m7pr changed the title 378 trim lines in format 378 trim_lines parameter in format Jul 10, 2023
@m7pr m7pr changed the base branch from main to filter_panel_refactor@main July 10, 2023 11:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R              8       0  100.00%
R/choices_labeled.R              49      14  71.43%   22, 33, 38, 48-53, 65, 69-73
R/count_labels.R                 98       0  100.00%
R/filter_panel_api.R             37       2  94.59%   89, 101
R/FilteredData-utils.R          117      17  85.47%   103-108, 201, 223-232
R/FilteredData.R                573     217  62.13%   100-103, 276-287, 508-516, 548-549, 608-617, 639, 660-701, 719-722, 738, 779-812, 827-829, 833-839, 865-894, 916-918, 922-924, 927-938, 942-951, 953-979, 1026, 1049-1067
R/FilteredDataset-utils.R        20       1  95.00%   133
R/FilteredDataset.R             179      67  62.57%   50, 146, 195-201, 229-286, 326-328
R/FilteredDatasetDefault.R      125       9  92.80%   69, 131, 141, 145, 231-235
R/FilteredDatasetMAE.R          134      37  72.39%   27, 113-118, 157-162, 166-167, 187-209
R/FilterPanelAPI.R               10       0  100.00%
R/FilterState-utils.R           133       1  99.25%   370
R/FilterState.R                 291      45  84.54%   211, 281, 325, 618-643, 654-673, 708-714, 723-729
R/FilterStateChoices.R          337     104  69.14%   291-294, 306, 334-340, 389-396, 400-417, 459-470, 480-498, 517-520, 523-526, 537-558, 571-572, 582-586, 588-592
R/FilterStateDate.R             229     141  38.43%   216-222, 235, 285-446
R/FilterStateDatettime.R        331     218  34.14%   253-259, 273, 323-567
R/FilterStateEmpty.R             63      41  34.92%   82, 92-97, 111, 125-176
R/FilterStateExpr.R              61      48  21.31%   138-231
R/FilterStateLogical.R          216     163  24.54%   127, 150, 206-212, 220, 223-421
R/FilterStateRange.R            435     131  69.89%   251, 348-354, 362, 385, 513-517, 520-530, 533, 545-551, 562-574, 578-588, 592-594, 608-635, 650-654, 656-660, 665-669, 671-675, 692-709, 744-749, 759-761
R/FilterStates-utils.R           70       9  87.14%   102, 121, 179-185, 207, 234
R/FilterStates.R                355      30  91.55%   76-80, 189, 322-331, 413-416, 459, 544-548, 593, 699-702
R/FilterStatesDF.R                5       0  100.00%
R/FilterStatesMAE.R              10       1  90.00%   39
R/FilterStatesMatrix.R            3       0  100.00%
R/FilterStatesSE.R              201     151  24.88%   34, 97-104, 112-119, 142-289
R/include_css_js.R                5       5  0.00%    12-16
R/teal_slice-store.R              7       7  0.00%    28-57
R/teal_slice.R                   92       2  97.83%   128, 193
R/teal_slices.R                 130       1  99.23%   188
R/test_utils.R                   21       0  100.00%
R/utils.R                        49       2  95.92%   101-102
R/variable_types.R               48      33  31.25%   41-46, 56, 69-104
R/zzz.R                          15      15  0.00%    3-46
TOTAL                          4457    1512  66.08%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/calls_combine_by.R             +1       0  +100.00%
R/count_labels.R                +98       0  +100.00%
R/filter_panel_api.R            +37      +2  +94.59%
R/FilteredData-utils.R          +19     -26  +29.35%
R/FilteredData.R                +68     -50  +15.00%
R/FilteredDataset-utils.R       +20      +1  +95.00%
R/FilteredDataset.R              -9     -10  +3.53%
R/FilteredDatasetDefault.R      +19      +1  +0.35%
R/FilteredDatasetMAE.R          -74     -22  +0.75%
R/FilterPanelAPI.R              -13      -8  +34.78%
R/FilterState-utils.R           -22     -14  +8.93%
R/FilterState.R                 +64     -43  +23.30%
R/FilterStateChoices.R         +168      +8  +25.94%
R/FilterStateDate.R             +64     +33  +3.88%
R/FilterStateDatettime.R        +93     +52  +3.89%
R/FilterStateEmpty.R            +22     +25  -26.05%
R/FilterStateExpr.R             +61     +48  +21.31%
R/FilterStateLogical.R          +78     +84  -18.22%
R/FilterStateRange.R           +210      +2  +27.22%
R/FilterStates-utils.R           +2      +4  -5.50%
R/FilterStates.R               +137     -63  +34.21%
R/FilterStatesDF.R             -225     -29  +12.61%
R/FilterStatesMAE.R            -211    -105  +37.96%
R/FilterStatesMatrix.R         -214    -108  +49.77%
R/FilterStatesSE.R             -208     -50  -25.98%
R/teal_slice-store.R             +7      +7  +100.00%
R/teal_slice.R                  +92      +2  +97.83%
R/teal_slices.R                +130      +1  +99.23%
R/test_utils.R                  +21       0  +100.00%
R/utils.R                       +10       0  +1.05%
R/zzz.R                          +9      +9  +100.00%
TOTAL                          +454    -249  +9.08%

Results for commit: aee8476

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    29 suites   29s ⏱️
366 tests 366 ✔️ 0 💤 0
804 runs  804 ✔️ 0 💤 0

Results for commit c116777.

Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👌

R/teal_slice.R Outdated Show resolved Hide resolved
m7pr and others added 2 commits July 10, 2023 13:44
Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr m7pr merged commit 7c5dc53 into filter_panel_refactor@main Jul 10, 2023
@m7pr m7pr deleted the 378_trim_lines_in_format@filter_panel_refactor@main branch July 10, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend format/print for all classes with trim_lines argument
2 participants