Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

867 modify mapping matrix #408

Merged
merged 7 commits into from
Aug 1, 2023
Merged

867 modify mapping matrix #408

merged 7 commits into from
Aug 1, 2023

Conversation

chlebowa
Copy link
Contributor

Related to this issue.

FilteredData receives a new public method, $get_available_teal_slices that returns the contents of the private field private$available_teal_slices.

@chlebowa chlebowa added the core label Jul 30, 2023
@chlebowa chlebowa mentioned this pull request Jul 30, 2023
Merged
@chlebowa chlebowa marked this pull request as ready for review July 30, 2023 15:17
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023 •
edited

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R              8       0  100.00%
R/choices_labeled.R              49      14  71.43%   22, 33, 38, 48-53, 65, 69-73
R/count_labels.R                 98       0  100.00%
R/filter_panel_api.R             37       2  94.59%   92, 104
R/FilteredData-utils.R          117      17  85.47%   103-108, 201, 223-232
R/FilteredData.R                585     223  61.88%   100-103, 167, 522-530, 599-608, 630, 651-692, 710-713, 729, 770-803, 818-820, 824-830, 856-885, 907-909, 913-915, 918-929, 933-942, 944-970, 988-1058, 1100, 1123-1141
R/FilteredDataset-utils.R        20       1  95.00%   133
R/FilteredDataset.R             179      67  62.57%   50, 149, 198-204, 232-289, 329-331
R/FilteredDatasetDefault.R      121       9  92.56%   69, 131, 141, 145, 228-232
R/FilteredDatasetMAE.R          134      37  72.39%   27, 113-118, 157-162, 166-167, 187-209
R/FilterPanelAPI.R               10       0  100.00%
R/FilterState-utils.R            97       1  98.97%   286
R/FilterState.R                 359      57  84.12%   88, 212, 230-234, 241-242, 298, 300, 302, 354, 399, 646, 689-714, 725-744, 779-785, 794-800
R/FilterStateChoices.R          344     115  66.57%   291-294, 306, 349, 373-380, 384-401, 430, 445-456, 468-476, 480-509, 530-533, 536-539, 550-571, 584-585, 595-599, 601-605
R/FilterStateDate.R             216     134  37.96%   218, 271-432
R/FilterStateDatettime.R        318     211  33.65%   255, 308-552
R/FilterStateEmpty.R             63      41  34.92%   82, 92-97, 111, 125-176
R/FilterStateExpr.R              65      52  20.00%   138-240
R/FilterStateLogical.R          208     156  25.00%   127, 150, 210, 213-411
R/FilterStateRange.R            431     123  71.46%   251, 375, 503-507, 510-520, 523, 535-541, 552-564, 568-578, 582-584, 598-625, 640-644, 646-650, 655-659, 661-665, 682-699, 734-739, 749-751
R/FilterStates-utils.R           70       9  87.14%   102, 121, 179-185, 207, 234
R/FilterStates.R                363      30  91.74%   76-80, 189, 321-330, 417-420, 463, 548-552, 597, 718-721
R/FilterStatesDF.R                5       0  100.00%
R/FilterStatesMAE.R              10       1  90.00%   39
R/FilterStatesMatrix.R            3       0  100.00%
R/FilterStatesSE.R              211     157  25.59%   34, 69-71, 81-83, 107-114, 122-129, 152-300
R/include_css_js.R                5       5  0.00%    12-16
R/teal_slice-store.R              7       7  0.00%    28-57
R/teal_slice.R                  102       2  98.04%   133, 197
R/teal_slices.R                 144       6  95.83%   138-143, 336
R/test_utils.R                   21       0  100.00%
R/utils.R                        49       2  95.92%   101-102
R/variable_types.R               48      33  31.25%   41-46, 56, 69-104
R/zzz.R                          15      15  0.00%    3-46
TOTAL                          4512    1527  66.16%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
R/FilteredData.R      +17      +1  +0.96%
TOTAL                 +17      +1  +0.11%

Results for commit: db00be9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023 •
edited

Unit Tests Summary

    1 files    28 suites   26s ⏱️
365 tests 365 ✔️ 0 💤 0 ❌
795 runs  795 ✔️ 0 💤 0 ❌

Results for commit aeb84bf.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Jul 31, 2023
gogonzo
gogonzo reviewed Jul 31, 2023
View reviewed changes
R/FilteredData.R Outdated Show resolved Hide resolved
gogonzo
gogonzo approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chlebowa chlebowa merged commit 91359a9 into main Aug 1, 2023
24 checks passed
@chlebowa chlebowa deleted the 867_mapping_matrix_NA@main branch August 1, 2023 07:06
chlebowa added a commit to insightsengineering/teal that referenced this pull request Aug 1, 2023
@chlebowa
867 modify mapping matrix (#879)
036eafa 
Fixes #867 
Fixes #878 

The mapping matrix is modified to display filters that cannot be applied
to a particular module as NA.

In `matrix_to_mapping` filters that are NA are treated as TRUE because
global filters may not apply to some modules.

Requires a new public method in `FilteredData`, introduced
[here](insightsengineering/teal.slice#408).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo gogonzo approved these changes

Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chlebowa @gogonzo