Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent naming ID for type_download_ui for table_with_settings and plot_with_settings #241

Open
m7pr opened this issue Apr 24, 2024 · 0 comments · May be fixed by #242
Open

Consistent naming ID for type_download_ui for table_with_settings and plot_with_settings #241

m7pr opened this issue Apr 24, 2024 · 0 comments · May be fixed by #242
Labels
core enhancement New feature or request

Comments

@m7pr
Copy link
Contributor

m7pr commented Apr 24, 2024 •
edited

Feature description

Currently we have 2 similar widgets: table_with_settings and plot_with_settings. Both of them have similar structure of UI and share the same naming convention of namespaces, besides one place in type_download_ui

teal.widgets/R/plot_with_settings.R

Line 554 in 3176ff5

inputId = ns("downl"),

teal.widgets/R/table_with_settings.R

Line 139 in 3176ff5

inputId = ns("dwnl"),

Such discrepancy was caught during automated tests in #240
@m7pr m7pr added enhancement New feature or request core labels Apr 24, 2024
m7pr added a commit that referenced this issue Apr 24, 2024
@m7pr
fix #241
7cf3b30
@m7pr m7pr linked a pull request Apr 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

241 unify namespace names for type_download_ui insightsengineering/teal.widgets
1 participant
@m7pr