Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shinytest2 tests #240

Merged
merged 54 commits into from
Apr 26, 2024
Merged

shinytest2 tests #240

merged 54 commits into from
Apr 26, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Apr 8, 2024

Part of #503

There is 4 functions that I am testing. There is a couple more, but we can do them in a separate PR.

@averissimo
Copy link
Contributor

averissimo commented Apr 8, 2024

Add {teal} to Suggests?

  • Does this circular dependency work?

@m7pr m7pr changed the title [DRAFT/WIP] shinytest2 tests shinytest2 tests Apr 17, 2024
@m7pr m7pr marked this pull request as ready for review April 17, 2024 14:33
Copy link
Contributor

github-actions bot commented Apr 17, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    58-153
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    50-190
R/plot_with_settings.R          382      22  94.24%   295-308, 330, 367-368, 379-380, 654-655, 657, 659
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   85
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   65-80, 106-107, 109, 117-145, 166
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1245     494  60.32%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/plot_with_settings.R        0      +1  -0.26%
TOTAL                         0      +1  -0.08%

Results for commit: c50115b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr
Copy link
Contributor Author

m7pr commented Apr 24, 2024

Hey @gogonzo I divided tests, and extended them with multiple resizing and download scenarios. In the end I decided just to leave

  • verbatim_popup
  • table_with_settings
  • plot_with_settings

as this was already huge PR.

Will continue with panel_group / panel_item somewhere else

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. I have not review verbatim popup yet

tests/testthat/test-plot_with_settings_ui.R Outdated Show resolved Hide resolved
tests/testthat/test-plot_with_settings_ui.R Outdated Show resolved Hide resolved
tests/testthat/test-plot_with_settings_ui.R Outdated Show resolved Hide resolved
tests/testthat/test-plot_with_settings_ui.R Outdated Show resolved Hide resolved
tests/testthat/test-plot_with_settings_ui.R Outdated Show resolved Hide resolved
tests/testthat/test-table_with_settings_ui.R Outdated Show resolved Hide resolved
tests/testthat/test-table_with_settings_ui.R Outdated Show resolved Hide resolved
tests/testthat/test-table_with_settings_ui.R Outdated Show resolved Hide resolved
m7pr and others added 10 commits April 25, 2024 10:43
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr
Copy link
Contributor Author

m7pr commented Apr 25, 2024

Hey @gogonzo I addresses comments. verbatim popup should be short :)

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

.github/workflows/check.yaml Show resolved Hide resolved
@m7pr m7pr enabled auto-merge (squash) April 26, 2024 10:18
@m7pr m7pr merged commit d7f4a7e into main Apr 26, 2024
25 checks passed
@m7pr m7pr deleted the shinytest2@main branch April 26, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants