Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps {rmarkdown} minimal version #244

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

averissimo
Copy link
Contributor

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/546

Necessary bump to overcome a lack of binary on ppm snapshots that causes an error on minimum strategies for scheduled workflows.

@averissimo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented May 16, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@averissimo averissimo marked this pull request as ready for review May 22, 2024 22:18
Copy link
Contributor

github-actions bot commented May 22, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    58-153
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    50-190
R/plot_with_settings.R          382      22  94.24%   295-308, 330, 367-368, 379-380, 654-655, 657, 659
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   85
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   65-80, 106-107, 109, 117-145, 166
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1245     494  60.32%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: de12154

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 22, 2024

Unit Tests Summary

  1 files   11 suites   1m 18s ⏱️
122 tests 118 ✅ 4 💤 0 ❌
323 runs  319 ✅ 4 💤 0 ❌

Results for commit de12154.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this May 23, 2024
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@averissimo averissimo merged commit d3098df into main May 24, 2024
33 of 34 checks passed
@averissimo averissimo deleted the 546-fix-verdepcheck@main branch May 24, 2024 00:41
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants