Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the size of sub-directories #1079

Closed
vedhav opened this issue Feb 1, 2024 · 1 comment
Closed

Reduce the size of sub-directories #1079

vedhav opened this issue Feb 1, 2024 · 1 comment
Assignees
@averissimo
Labels
core

Comments

@vedhav
Copy link
Contributor

vedhav commented Feb 1, 2024

As we have extensive docs for teal. The docs and help directory is populated with a lot of files.
We need to reduce the file size as we get a NOTE from R CMD check.

Possible solutions are to investigate unwanted files. Convert/Shrink them. Or remove and replace them with assets from a CDN.
@chlebowa chlebowa added the core label Feb 1, 2024
@chlebowa chlebowa modified the milestone: GRAN Feb 1, 2024
@chlebowa chlebowa mentioned this issue Feb 1, 2024
Closed
36 tasks
@averissimo
Copy link
Contributor

This size should be enough for the documentation: https://github.com/insightsengineering/hex-stickers/blob/main/thumbs/teal.png

@averissimo averissimo self-assigned this Feb 1, 2024
@averissimo averissimo mentioned this issue Feb 1, 2024
Merged
3 tasks
averissimo added a commit that referenced this issue Feb 5, 2024
@averissimo @vedhav
Reduces the size of sub-directories (#1082)
f417317 
# Pull Request

<!--- Replace `#nnn` with your issue link for reference. -->

Fixes #1079

note: `base branch` is `1076_....` as that has a fix for a test that is
failing. `main` branch doesn't have one of the images that is being
optimized

### Changes description

- [x] Use a smaller logo file
- [x] Remove embedded PNG on SVG
- [x] Reduce gif

---------

Co-authored-by: Aleksander Chlebowski <aleksander.chlebowski@contractors.roche.com>
Co-authored-by: vedhav <vedhaviyash4@gmail.com>
@chlebowa chlebowa closed this as completed Feb 6, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averissimo averissimo

Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@averissimo @vedhav @chlebowa