Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests wait for idle by default after setting module input #1200

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Tests wait for idle by default after setting module input #1200

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccb0709
feat: wait for idle by default after setting module input
averissimo Apr 11, 2024
7db0954
Merge branch 'main' into wait_for_idle@main
averissimo Apr 11, 2024
ae35674
fix: remove duration from wait_for_idle(5000) it will reduce executio…
averissimo Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion R/TealAppDriver.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ TealAppDriver <- R6::R6Class( # nolint: object_name.
#' @param ... arguments passed to parent [`shinytest2::AppDriver`] `click()` method.
click = function(...) {
super$click(...)
self$wait_for_idle(5000)
self$wait_for_idle()
averissimo marked this conversation as resolved.
Show resolved Hide resolved
},
#' @description
#' Check if the app has shiny errors. This checks for global shiny errors.
Expand Down Expand Up @@ -232,6 +232,8 @@ TealAppDriver <- R6::R6Class( # nolint: object_name.
value,
...
)
dots <- rlang::list2(...)
if (!isFALSE(dots[[wait]])) self$wait_for_idle() # Default behavior is to wait
invisible(self)
},
#' @description
Expand Down
Loading