Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] Support react-lite #73

Closed
alexeybondarenko opened this issue Nov 2, 2016 · 3 comments
Closed

[Question] Support react-lite #73

alexeybondarenko opened this issue Nov 2, 2016 · 3 comments

Comments

@alexeybondarenko
Copy link
Contributor

I've tried to use masked-input with react-lite, but it not works because masked-input uses internal react modules. It'is possible to implement masked input without lib/ReactInputSelection access?

Lucifier129/react-lite#81
@alexeybondarenko alexeybondarenko changed the title Support react-lite [Question] Support react-lite Nov 2, 2016
@iamdustan
Copy link
Collaborator

Oi! This is using react-internals? 😬

That definitely needs to be rectified...

@jquense
Copy link
Collaborator

jquense commented Nov 2, 2016

i have a hand written version at: https://github.com/jquense/react-widgets/blob/master/src/util/caret.js i'm sure there are also like 1351356 other options on npm. so Yeha it should be easy enough to not rely on the internals

@alexeybondarenko
Copy link
Contributor Author

#74 I've made PR

iamdustan added a commit that referenced this issue Nov 14, 2016
@iamdustan
Issue #73: remove react internals (#74)
e39c44f 
* removed react internals

* lint fix

* fixed by eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iamdustan @jquense @alexeybondarenko